Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[53810] Update PageHeaders & SubHeaders in the (rails) project pages #17103

Merged
Merged
Changes from 1 commit
Commits
Show all changes
64 commits
Select commit Hold shift + click to select a range
e12f11b
update page header in project settings
bsatarnejad Oct 31, 2024
92c8bf9
remove confirmation from templated button
bsatarnejad Nov 2, 2024
2a5450e
add page header fo adding news
bsatarnejad Nov 2, 2024
6988b01
update page header in roadmap
bsatarnejad Nov 4, 2024
0199254
update page header in new version page
bsatarnejad Nov 4, 2024
a2ed799
update page header in new versions page
bsatarnejad Nov 4, 2024
ce34cf2
update page header in forums
bsatarnejad Nov 5, 2024
2da1820
update page header in new forum page
bsatarnejad Nov 5, 2024
400c3cc
move create button form header to subheader in versions pages
bsatarnejad Nov 5, 2024
723eb33
change header in new board page
bsatarnejad Nov 5, 2024
c86bcc2
change header in backlogs page
bsatarnejad Nov 5, 2024
4b08052
change header in edit version page
bsatarnejad Nov 6, 2024
b7ce95a
change html title in edit version page
bsatarnejad Nov 6, 2024
45656db
change page header in budget page
bsatarnejad Nov 10, 2024
93a78fa
change page header in forum index page and change class of watcher li…
bsatarnejad Nov 11, 2024
e60dd48
change page header in forum new message page
bsatarnejad Nov 11, 2024
a963711
update page header in budget new page
bsatarnejad Nov 11, 2024
4e7d693
update page header in budget show page
bsatarnejad Nov 11, 2024
d4b7717
update page header in budget edit page
bsatarnejad Nov 11, 2024
8e7bb61
add a confirmation for delete method in budget form
bsatarnejad Nov 11, 2024
3013dd1
move header action to subheader in forums
bsatarnejad Nov 12, 2024
989b8b4
update page header in edit forum page
bsatarnejad Nov 12, 2024
567c401
update page header in documents pages
bsatarnejad Nov 12, 2024
e397666
update page header in work package categories pages
bsatarnejad Nov 12, 2024
18de94e
update page header in boards pages
bsatarnejad Nov 13, 2024
d814a0e
update page header in boards pages
bsatarnejad Nov 13, 2024
e99ade6
update page header in new calendar page
bsatarnejad Nov 13, 2024
ccbf1e6
update page header in destroy category page
bsatarnejad Nov 13, 2024
f39f61c
change page header breadcrumbs for edit and destroy categories
bsatarnejad Nov 13, 2024
21178a2
change watcher helper that can be used in page header action buttons
bsatarnejad Nov 13, 2024
63f7a24
change watcher helper that can be used in page header action buttons
bsatarnejad Nov 13, 2024
8e88414
update page header in show and edit pages of news
bsatarnejad Nov 13, 2024
1ff2d46
update page header in taskboard of backlogs
bsatarnejad Nov 14, 2024
4a8adaf
update page header in version page
bsatarnejad Nov 15, 2024
42647ff
update page header in edit budgets page
bsatarnejad Nov 16, 2024
6a95322
update page header in forum and messages pages
bsatarnejad Nov 16, 2024
b36ac71
update page header in documents pages
bsatarnejad Nov 16, 2024
09cf15c
update page header in edit version pages
bsatarnejad Nov 16, 2024
589f711
update page header in change identifier project
bsatarnejad Nov 16, 2024
dd7fbda
update page header in new project
bsatarnejad Nov 16, 2024
82c7aee
update page header in destroy project
bsatarnejad Nov 16, 2024
de07f40
update page header in copy project
bsatarnejad Nov 16, 2024
b17b897
update page header in repository pages of a project
bsatarnejad Nov 17, 2024
16e91c6
update page header in storages pages of a project
bsatarnejad Nov 17, 2024
bd3fb3e
Merge branch 'dev' into 53810-update-pageheaders-subheaders-in-the-ra…
bsatarnejad Nov 17, 2024
29e336a
update page header in attachment tab in storages of a project
bsatarnejad Nov 17, 2024
5c7ec9e
Replace pageHeaders with "check all/uncheck all" links with Primer co…
HDinger Nov 25, 2024
41ace84
Correct some usages of Primer::PageHeader
HDinger Nov 25, 2024
a581547
Replace rails toolbars with Primer::PageHeader in BCF module
HDinger Nov 25, 2024
087dad8
Replace some more PageHeaders with the Primer component
HDinger Nov 25, 2024
5356b49
Merge branch 'dev' into 53810-update-pageheaders-subheaders-in-the-ra…
HDinger Nov 26, 2024
681dcf2
Extract project settings pageHeader into a separate component
HDinger Nov 26, 2024
a180964
Adapt tests to new PageHeader structure
HDinger Nov 26, 2024
a7c0b0a
Move watcher helper inside the module
HDinger Nov 26, 2024
9024b58
Merge branch 'dev' into 53810-update-pageheaders-subheaders-in-the-ra…
HDinger Nov 28, 2024
cc93046
Replace PageHeaders for storage member page
HDinger Nov 28, 2024
f638ab3
Merge branch 'dev' into 53810-update-pageheaders-subheaders-in-the-ra…
bsatarnejad Dec 3, 2024
f5930b5
fix rubocup error and reduce its Assignment Branch Condition size and…
bsatarnejad Dec 3, 2024
a4904fb
Move PageHeader into their own components and fix some tests
HDinger Dec 5, 2024
cd1e321
Fix some more tests
HDinger Dec 5, 2024
381951f
Merge remote-tracking branch 'origin/dev' into 53810-update-pageheade…
HDinger Dec 5, 2024
18c4b67
Remove unused label
HDinger Dec 5, 2024
2e78147
fix failing test in messages of a forum
bsatarnejad Dec 5, 2024
9f8cf59
Fix some specs
HDinger Dec 5, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
move header action to subheader in forums
  • Loading branch information
bsatarnejad committed Nov 12, 2024
commit 3013dd14929420c7dc09cc9fd864eaf14c840bdf
21 changes: 11 additions & 10 deletions app/views/forums/index.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -35,20 +35,21 @@ See COPYRIGHT and LICENSE files for more details.
{ href: project_overview_path(@project.id), text: @project.name },
t(:label_forum_plural)
])
if User.current.allowed_in_project?(:manage_forums, @project)
header.with_action_button(scheme: :primary,
mobile_icon: :plus,
mobile_label: t(:label_forum_new),
aria: { label: t(:label_forum_new) },
title: t(:label_forum_new),
tag: :a,
href: new_project_forum_path(@project)) do |button|
end %>
<% if User.current.allowed_in_project?(:manage_forums, @project) %>
<%=
render(Primer::OpenProject::SubHeader.new) do |subheader|
subheader.with_action_button(scheme: :primary,
aria: { label: t(:label_forum_new) },
title: t(:label_forum_new),
tag: :a,
href: new_project_forum_path(@project)) do |button|
button.with_leading_visual_icon(icon: :plus)
t('activerecord.models.forum')
end
end
end %>

%>
<% end %>
<% if @forums.empty? %>
<%= no_results_box(action_url: new_project_forum_path(@project)) %>
<% else %>
Expand Down