Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused code #17301

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Remove unused code #17301

merged 3 commits into from
Nov 29, 2024

Conversation

HDinger
Copy link
Contributor

@HDinger HDinger commented Nov 28, 2024

There are two templates that are never used and thus removed

  • Boards/overview (no route exists for that, was removed in this scope)
  • Bcf/issues: the controller directly redirects to another route (checked with @Kharonus)

@HDinger HDinger added this to the 15.2.x milestone Nov 28, 2024
@cbliard cbliard self-assigned this Nov 28, 2024
cbliard
cbliard requested changes Nov 28, 2024
View reviewed changes
Copy link
Member

@cbliard cbliard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always nice to see some code deleted 👍

In only found this piece missing: in modules/bim/lib/open_project/bim/engine.rb, lines 60 and 65, the permissions are referencing the index action that you just removed.

@HDinger
Copy link
Contributor Author

HDinger commented Nov 29, 2024

Always nice to see some code deleted 👍

In only found this piece missing: in modules/bim/lib/open_project/bim/engine.rb, lines 60 and 65, the permissions are referencing the index action that you just removed.

Good catch 👍 I updated the permissions /cc @Kharonus

@HDinger HDinger requested a review from cbliard November 29, 2024 07:23
@cbliard cbliard merged commit 2dd1c4d into dev Nov 29, 2024
11 checks passed
@cbliard cbliard deleted the housekeeping/remove-unused-code branch November 29, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbliard cbliard cbliard approved these changes

Assignees

@cbliard cbliard

Labels
maintenance
Milestone
15.2.x
Development

Successfully merging this pull request may close these issues.
2 participants
@HDinger @cbliard