Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code #17301

Merged
merged 3 commits into from
Nov 29, 2024
+3 −75
Merged

Remove unused code #17301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1acc2b8
Remove unused route and its template
HDinger Nov 28, 2024
0180ad4
Remove unused template
HDinger Nov 28, 2024
dde5595
Update permissions since the index route does not exist any more
HDinger Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions modules/bim/app/controllers/bim/bcf/issues_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,6 @@ class IssuesController < BaseController

def upload; end

def index
redirect_to action: :upload
end

def prepare_import
render_next
rescue StandardError => e
Expand Down
28 changes: 0 additions & 28 deletions modules/bim/app/views/bim/bcf/issues/index.html.erb
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion modules/bim/config/routes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
scope "projects/:project_id", as: "project" do
get "bcf/menu" => "bim/menus#show"

resources :issues, controller: "bim/bcf/issues" do
resources :issues, controller: "bim/bcf/issues", except: :index do
get :upload, action: :upload, on: :collection
post :prepare_import, action: :prepare_import, on: :collection
post :configure_import, action: :configure_import, on: :collection
Expand Down
4 changes: 2 additions & 2 deletions modules/bim/lib/open_project/bim/engine.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,12 @@ class Engine < ::Rails::Engine
dependencies: %i[view_ifc_models],
contract_actions: { ifc_models: %i[create update destroy] }
permission :view_linked_issues,
{ "bim/bcf/issues": %i[index] },
{},
permissible_on: :project,
dependencies: %i[view_work_packages],
contract_actions: { bcf: %i[read] }
permission :manage_bcf,
{ "bim/bcf/issues": %i[index upload prepare_import configure_import perform_import] },
{ "bim/bcf/issues": %i[upload prepare_import configure_import perform_import] },
permissible_on: :project,
dependencies: %i[view_linked_issues
view_work_packages
Expand Down
40 changes: 0 additions & 40 deletions modules/boards/app/views/boards/boards/overview.html.erb
View file
Open in desktop

This file was deleted.