Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use service to clean sessions #17383

Merged
merged 2 commits into from
Dec 8, 2024

Update app/services/sessions/clear_old_sessions_service.rb

a954219
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Use service to clean sessions #17383

Update app/services/sessions/clear_old_sessions_service.rb
a954219
Select commit
Loading
Failed to load commit list.
GitHub Actions / rubocop failed Dec 8, 2024 in 0s

reviewdog [rubocop] report

reported by reviewdog 🐶

Findings (1)

app/services/sessions/clear_old_sessions_service.rb|35 col 45| Use where(updated_at: ...days_ago.days.ago) instead of manually constructing SQL.

Filtered Findings (0)

Annotations

Check notice on line 35 in app/services/sessions/clear_old_sessions_service.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] app/services/sessions/clear_old_sessions_service.rb#L35 <Rails/WhereRange> 

Use `where(updated_at: ...days_ago.days.ago)` instead of manually constructing SQL.
Raw output 
app/services/sessions/clear_old_sessions_service.rb:35:45: C: Rails/WhereRange: Use `where(updated_at: ...days_ago.days.ago)` instead of manually constructing SQL.
View more details on GitHub Actions