wrap form autocompleters into primer form classes #17482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toy
force-pushed
the
feature/58161-global-stage-administration
branch
from
b63fae5 to
d66c408
Compare
ulferts
force-pushed
the
fix/wrap_form_autocompleters_into_primer_form_classes
branch
from
81d37f0 to
d24ffde
Compare
ulferts
changed the base branch from
feature/58161-global-stage-administration
to
dev
3 tasks
HDinger
approved these changes
Dec 18, 2024
ulferts
deleted the
fix/wrap_form_autocompleters_into_primer_form_classes
branch
toy
added a commit
that referenced
this pull request
Dec 18, 2024
toy
added a commit
that referenced
this pull request
Dec 18, 2024
toy
added a commit
that referenced
this pull request
Dec 18, 2024
toy
added a commit
that referenced
this pull request
Jan 6, 2025
toy
added a commit
that referenced
this pull request
Jan 6, 2025
toy
added a commit
that referenced
this pull request
Jan 7, 2025
toy
added a commit
that referenced
this pull request
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Wraps the OP specific form inputs for autocompletion (work package, project, color and the generic autocompleter) into a div just like the input fields provided by primer. That div then receives the css classes the primer inputs receive as well. Additionally, it allows providing the
input_widthparameter so that the width of the input is limited when needed.Before the change, the dom structure for the color autocompleter looks like this:
After, it looks like this:
That change is then applied to the status form where the color select now has the same width as the input for the name attribute:
The PR also adds a preview for the color select which was missing before.