-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experimental changes for referrers API, ORAS artifact manifest support #5
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Aviral Takkar <aviral26@users.noreply.github.com>
CI: add oras-project/registry image release
Signed-off-by: Aviral Takkar <aviral26@users.noreply.github.com>
Signed-off-by: Aviral Takkar <aviral26@users.noreply.github.com>
Signed-off-by: Aviral Takkar <aviral26@users.noreply.github.com>
/cc @michaelb990 |
Signed-off-by: Aviral Takkar <aviral26@users.noreply.github.com>
Can you update the PR text to reflect #17 is merged? |
│ └── link | ||
└── 333ic0c33ebc4a74a0a554c86ac2b28ddf3454a5ad9cf90ea8cea9f9e75c333i | ||
└── link | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we support up a configuration that would enable this API?
Signed-off-by: Aviral Takkar <aviral26@users.noreply.github.com>
Signed-off-by: Aviral Takkar <aviral26@users.noreply.github.com>
Draft guidance for submitting changes to upstream - https://hackmd.io/batGDY9cSnetgdrAmbVm6g BranchesThis follows guidelines similar to Kubernetes changes gets pushed to upstream.
PR hygiene
|
Signed-off-by: Aviral Takkar <aviral26@users.noreply.github.com>
│ ├── digest(application/vnd.example.artifact) | ||
│ │ └── sha256 | ||
│ │ └── 222ibbf80b44ce6be8234e6ff90a1ac34acbeb826903b02cfa0da11c82cb222i | ||
│ │ └── link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another thought is to have a separate folder for references
v<root>
└── v2
└── repositories
└── nginx
├── _manifests
│ └── revisions
│ └── sha256
│ ├── 111ma2d22ae5ef400769fa51c84717264cd1520ac8d93dc071374c1be49a111m
│ │ ├── link
│ ├── 222ibbf80b44ce6be8234e6ff90a1ac34acbeb826903b02cfa0da11c82cb222i
│ │ └── link
│ └── 333ic0c33ebc4a74a0a554c86ac2b28ddf3454a5ad9cf90ea8cea9f9e75c333i
│ └── link
└── _references
└── subjects
└── sha256
└── 111ma2d22ae5ef400769fa51c84717264cd1520ac8d93dc071374c1be49a111m
├── digest(application/vnd.example.artifact)
│ └── sha256
│ └── 222ibbf80b44ce6be8234e6ff90a1ac34acbeb826903b02cfa0da11c82cb222i
│ └── link <to manifest in _manifests>
└── digest(application/vnd.another.example.artifact)
└── sha256
└── 333ic0c33ebc4a74a0a554c86ac2b28ddf3454a5ad9cf90ea8cea9f9e75c333i
└── link <to manifest in _manifests>
Couple of benefits are, it aligns with the current model where separate folder exists for entity type like manifests, tags, layers etc. In the similar fashion references
will represent index for all referrers. In addition , if we extend references to layers, this model can still be used except for that the link refers to _layers blob and doesn't need any change to the _layers folder. Also, there will be no change to the existing folders and hence existing systems need not be checked for any unexpected behaviors with this new structure under _manifests.
} | ||
|
||
// Validate subject manifest. | ||
subject := dm.SubjectManifest() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subject is optional, so you may want to check only if it is present
vendor/github.com/oras-project/artifacts-spec/specs-go/v1/manifest.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Aviral Takkar <aviral26@users.noreply.github.com>
This PR addresses a subset of tasks mentioned in #4 and adds experimental changes that support:
Further reading on usage is available at
README.md
and implementation atdocs/referrers.md
.