-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SYNC_ASSETS_HOOK support #6131
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6131 +/- ##
=======================================
Coverage 98.99% 98.99%
=======================================
Files 396 396
Lines 39611 39618 +7
=======================================
+ Hits 39211 39218 +7
Misses 400 400 ☔ View full report in Codecov by Sentry. |
This is useful when having site-local cache shared among several worker hosts. See added documentation for scenario details.
f76e979
to
6960512
Compare
ping? |
commit e206546 Merge: 493cce4 6960512 Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> AuthorDate: Thu Feb 6 17:00:31 2025 +0000 Commit: GitHub <[email protected]> CommitDate: Thu Feb 6 17:00:31 2025 +0000 Merge pull request os-autoinst#6131 from marmarek/sync-assets-hook Add SYNC_ASSETS_HOOK support
I would suggest to add that new variable here: https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/Worker/Job.pm#L240 |
Sure I can add it there. I included question about it in the PR description:
TBH, I'm not sure what is the rule what settings are allowed only in workers.ini and what can be set via jobs. There are many variables that can take paths that may or may not be specific to individual worker filesystem layout (like several of |
It's possible that there are more variables that should be only allowed via workers.ini. |
SYNC_ASSETS_HOOK was added in os-autoinst#6131 Since it is a setting supposed for the workers.ini, we should disallow it in the job settings.
I created #6160 |
This is useful when having site-local cache shared among several worker
hosts. See added documentation for scenario details.
Question: Should this setting be also exclusive to workers.ini, similar to
GENERAL_HW_CMD_DIR
and few others?