Restrict SYNC_ASSETS_HOOK to worker settings #6160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SYNC_ASSETS_HOOK was added in os-autoinst#6131 Since it is a setting supposed for the workers.ini, we should disallow it in the job settings.
marmarek
approved these changes
Feb 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6160 +/- ##
=======================================
Coverage 98.99% 98.99%
=======================================
Files 396 396
Lines 39691 39691
=======================================
Hits 39291 39291
Misses 400 400 ☔ View full report in Codecov by Sentry. |
baierjan
approved these changes
Feb 7, 2025
okurz
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SYNC_ASSETS_HOOK was added in #6131
Since it is a setting supposed for the workers.ini, we should disallow it in the job settings.