fix(proxy): simplify URL construction in pagination links (#36)

[sikatikenmogne]

Related Issues

• Fixes Issue with proxy forwarder #36

Changes (initial)

• Added a new helper function called removeDomain to handle URL parsing and remove the domain from the given full URL.
• Updated the constructUrl helper function to use removeDomain for constructing clean URLs.
• Modified the pagination.hbs template to use removeDomain in the href attribute of the page links.

After review

• Simplifying URL construction by removing @root.fullUrl host part

Preview

2024-08-26-16-59-42.mp4

Tested environments

• Github Codespaces
• Windows
• Microsoft DevContainer

[sikatikenmogne]

Hi @pythonbrad, thanks' for your review. I've applied your suggestion and reverted my commit about the helper function.
If you decide not to merge this branch, I’ve also opened a separate PR (#38) that addresses only the suggested changes. I hope you will appreciate it.

[pythonbrad]

Ok good, when I will test it, I will inform you.

[pythonbrad]

@sikatikenmogne, it's not good to push more than one pr who solve the same issue.

[sikatikenmogne]

@sikatikenmogne, it's not good to push more than one pr who solve the same issue.

I know, I just thought it would be better to summarize the changes in this conversation in a one commit pull request instead of a 3 which looks a bit messy, feel free to close the pull request which seems like too much.

[sikatikenmogne]

I've closed the PR #38

[sikatikenmogne]

@rakici

[rakici]

Nice catch.