Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: simplify URL construction by removing fullUrl host part #38

Closed
wants to merge 1 commit into from
Closed

refactor: simplify URL construction by removing fullUrl host part #38

wants to merge 1 commit into from

Conversation

sikatikenmogne
Copy link
Contributor

This PR relates to issues #36, fix the pagination URL redirection problem by removing the host part of the fullUrl variable in index.ts

Changes

Preview

2024-08-26-16-59-42.mp4

How to Test

  1. Ensure you have installed dependencies by running yarn install.
  2. Start the application with yarn run dev or yarn start.
  3. Navigate through the pagination component and confirm that URLs are correctly formatted and redirections work as expected.

Tested environments

  • Github Codespaces
  • Windows
  • Microsoft DevContainer

Related Issues

Related Pull Request

@sikatikenmogne sikatikenmogne mentioned this pull request Aug 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with proxy forwarder
1 participant
@sikatikenmogne