Upgrading to widget-code-input 4 and adding tests for lab 4 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoscinski
added a commit
that referenced
this pull request
Jul 1, 2024
The new widget_code_input introudces completely style of the WidgetCodeInput that introduces the widgets tests to fail. We will upgrade to widget_code_input 4 in a dedicated PR. See PR #45.
agoscinski
added a commit
that referenced
this pull request
Jul 1, 2024
The new widget_code_input introudces completely style of the WidgetCodeInput that introduces the widgets tests to fail. We will upgrade to widget_code_input 4 in a dedicated PR. See PR #45.
agoscinski
added a commit
that referenced
this pull request
Jul 1, 2024
The new widget_code_input introudces completely style of the WidgetCodeInput that introduces the widgets tests to fail. We will upgrade to widget_code_input 4 in a dedicated PR. See PR #45.
agoscinski
force-pushed
the
support-wci4
branch
3 times, most recently
from
64bb196 to
4db9629
Compare
This was referenced Jul 2, 2024
In lab 4 the `ipympl.backend_nbagg` backend is called `widget`.
We need to check the jupyter version to set the globals, the version is only available when running a notebooki. The easiest way is do it within a test. Opened issue #51 to implement this cleaner.
agoscinski
force-pushed
the
support-wci4
branch
2 times, most recently
from
5dbb878 to
bf34553
Compare
The privacy button class name changed in lab 4.
In lab 4 jupyter cells load their content only when in view, so we implement a scrolling behavior into the class NotebookCell that jumps to the beginning of the ipynb and then scrolls down the list to the target.
In lab 4 one needs to click one time on the window to use a button. This click causes the tests to fail for lab 3 because of the window size being to small so we only enable the click in lab 4
The matplotlib test loads all figures at once, but for lab they have to be loaded and tested when in view. We disable this test for lab 4 and put this as task for later. See issue #52.
We add pytest-rerun to tests and allow the tests to be rerun up to 3 times until they pass. The tests for lab 4 are less stable and fail at different points for different reasons that are hard to fix. By allowing the tests to pass with a rerun we avoid these kind of issues.
agoscinski
changed the title
agoscinski
added a commit
that referenced
this pull request
Jul 4, 2024
With widget_code_input 4 the WidgetCodeInput can now be used in lab 4. The tests have been updated to test support lab 4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to widget_code_input version 4 and tests for lab 4
📚 Documentation preview 📚: https://scicode-widgets--45.org.readthedocs.build/en/45/