-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark Mode Issues: Unreadable ORA Elements and Visibility Problems #107
Comments
Hello. Adding a status update for this issue below 1. ORA Response and Rubric Colors Render UnreadableWe have identified the issues and are working on fixing them. The work-in progress has been created and will be merged as soon as the relevant issues have been fixed #111. 2. Dark Mode Compatibility Issues Across Handouts and Updates SectionsSince the issue touches various sections of the platform, I am going to add context for each where possible. Handouts and UpdatesCourse updates and handouts are rendered via iframe. However, the dark theme fixups can be done because these iframes are rendered via srcdoc instead of src. Notes, Teams, and Textbooks TabsThese tab do not have any dark theme related CSS in Indigo. We will be doing a quick fix for them, though it is possible we might do a rehaul of those later. If we run into any issues with either tab, we will update the issue. WikiThe group dropdown in settings is readable in dark theme. Discussions SidebarThe discussion sidebar is rendered as an iframe from discussions MFE. It might not be fixed immediately. We will create a follow-up issue for that. cc: @hinakhadim |
Part 1: "ORA Response and Rubric Colors Render Unreadable" PR is ready. |
PR to fix "Course Updates and Handouts" is ready. |
PR to fix teams tab dark theme compatibility issues #114 |
PR to fix Notes and Textbook for dark-theme: #115 |
Closing this issue as all the points are completed and the PRs are merged. cc: @DawoudSheraz |
Description
This issue highlights several problems with the dark mode implementation in the Tutor-Indigo theme. These issues affect the readability and usability of specific sections in the Open edX platform when dark mode is enabled. They were originally flagged during the Sumac release testing but have been identified as theme-specific and tied to Indigo.
During a recent BTR meeting, it was decided that theme-specific testing, such as addressing dark mode issues in the Indigo theme, would be under the responsibility of the theme maintainers. You can find more details here: https://openedx.atlassian.net/wiki/spaces/COMM/pages/4551147558/2024-11-04+BTR+Meeting+Minutes. Below are the details of the reported issues:
Reported Issues
1. ORA Response and Rubric Colors Render Unreadable
All parts of the Open Response Assessment (ORA) interface should be easily readable in dark mode.
Some text and UI elements within the ORA become difficult to read or entirely invisible due to incompatible colors in the dark mode color scheme.
https://jam.dev/c/0590feb8-01b0-455c-8ef1-b40fbf8f3780)
2. Dark Mode Compatibility Issues Across Handouts and Updates Sections
All interface sections, including Handouts and Updates, should be readable and visually compatible with dark mode settings.
Handouts and Updates sections display a white background, leading to a jarring visual mismatch and reduced readability.
The text was updated successfully, but these errors were encountered: