Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode Issues: Unreadable ORA Elements and Visibility Problems #107

Closed
magajh opened this issue Dec 2, 2024 · 7 comments
Closed

Dark Mode Issues: Unreadable ORA Elements and Visibility Problems #107

magajh opened this issue Dec 2, 2024 · 7 comments
Assignees

Comments

@magajh
Copy link

magajh commented Dec 2, 2024

Description

This issue highlights several problems with the dark mode implementation in the Tutor-Indigo theme. These issues affect the readability and usability of specific sections in the Open edX platform when dark mode is enabled. They were originally flagged during the Sumac release testing but have been identified as theme-specific and tied to Indigo.

During a recent BTR meeting, it was decided that theme-specific testing, such as addressing dark mode issues in the Indigo theme, would be under the responsibility of the theme maintainers. You can find more details here: https://openedx.atlassian.net/wiki/spaces/COMM/pages/4551147558/2024-11-04+BTR+Meeting+Minutes. Below are the details of the reported issues:


Reported Issues

1. ORA Response and Rubric Colors Render Unreadable


2. Dark Mode Compatibility Issues Across Handouts and Updates Sections

@DawoudSheraz
Copy link
Contributor

DawoudSheraz commented Dec 4, 2024

Hello. Adding a status update for this issue below

1. ORA Response and Rubric Colors Render Unreadable

We have identified the issues and are working on fixing them. The work-in progress has been created and will be merged as soon as the relevant issues have been fixed #111.

2. Dark Mode Compatibility Issues Across Handouts and Updates Sections

Since the issue touches various sections of the platform, I am going to add context for each where possible.

Handouts and Updates

Course updates and handouts are rendered via iframe. However, the dark theme fixups can be done because these iframes are rendered via srcdoc instead of src.

Notes, Teams, and Textbooks Tabs

These tab do not have any dark theme related CSS in Indigo. We will be doing a quick fix for them, though it is possible we might do a rehaul of those later. If we run into any issues with either tab, we will update the issue.

Wiki

The group dropdown in settings is readable in dark theme.

image
Discussions Sidebar

The discussion sidebar is rendered as an iframe from discussions MFE. It might not be fixed immediately. We will create a follow-up issue for that.

cc: @hinakhadim

@hinakhadim
Copy link
Collaborator

Part 1: "ORA Response and Rubric Colors Render Unreadable" PR is ready.

@hinakhadim
Copy link
Collaborator

PR to fix "Course Updates and Handouts" is ready.

@DawoudSheraz
Copy link
Contributor

PR to fix teams tab dark theme compatibility issues #114

@hinakhadim
Copy link
Collaborator

PR to fix Notes and Textbook for dark-theme: #115

@hinakhadim
Copy link
Collaborator

Closing this issue as all the points are completed and the PRs are merged.
Another issue will be created for discussion sidebar follow-up.

cc: @DawoudSheraz

@github-project-automation github-project-automation bot moved this from In Progress to Done in Tutor project management Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants