Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ORA dark theme compatibility updates #111

Merged
merged 5 commits into from
Dec 6, 2024
Merged

Conversation

DawoudSheraz
Copy link
Contributor

@DawoudSheraz DawoudSheraz commented Dec 3, 2024

Fix multiple dark theme issues with ORA xblock

Closes (task 1 of) #107

Style Changes for ORA:

  • image

  • image

  • image

  • image

  • image

  • image

Copy link
Contributor Author

@DawoudSheraz DawoudSheraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes locally, they are working as expected.
A changelog-entry is needed.

Copy link
Contributor

@Danyal-Faheem Danyal-Faheem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes. They're looking good!

Just needs a changelog entry and it's good to go.

@hinakhadim hinakhadim merged commit 8f1ae4d into release Dec 6, 2024
1 check passed
@hinakhadim hinakhadim deleted the ora-dark-theme-fixups branch December 6, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants