fix: add dark-theme to iframes that has srcDoc attribute #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -64,4 +98,4 @@ const config = { | |||
| }, | |||
| }; | |||
|
|
|||
| export default config; | |||
| export default config; | |||
There was a problem hiding this comment.
nit: extra line at end
Danyal-Faheem
approved these changes
Dec 5, 2024
|
Can you also add a changelog entry? |
DawoudSheraz
reviewed
Dec 6, 2024
DawoudSheraz
reviewed
Dec 6, 2024
DawoudSheraz
approved these changes
Dec 6, 2024
hinakhadim
force-pushed
the
fix/dark-theme-course-handouts
branch
from
82eee01 to
0aebd87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Course Handouts and Updates Fixes:
The Course handouts and Updates are rendered via Iframe in Learning MFE. The Iframes are using
srcDocattribute so we can append dark colors to it when User has enabled dark theme.Steps:
3.2.2(https://www.npmjs.com/package/@edly-io/indigo-frontend-component-header/v/3.2.2)env.config.jsxto add dark-theme in iframes (if enabled) when page is loaded.This PR covers updating
env.config.jsx. And header package is already done.Closes (part 2-i of) #107