fix: add dark-theme to notes and textbook page #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DawoudSheraz
reviewed
Dec 9, 2024
| color: $dark; | ||
| border-color: $primary; | ||
| } | ||
| .wrapper-course-material[aria-label="Course Material"] { |
There was a problem hiding this comment.
nit: any reason for moving it out of all body selectors?
There was a problem hiding this comment.
Yes, The wrapper-course-material is available on all pages (instructors, teams, wiki, static-page). so, if there is notes page and textbook page, we have to add body.notes for Notes page. For textbook page, there is no such class with body tag (it has <body classname="indigo-dark-theme lang_en ltc" /> these classes). So, to apply on textbook page, I've made it generic and moved out of body classes. Also made it specific to tabs using the aria-label attribute.
DawoudSheraz
reviewed
Dec 9, 2024
hinakhadim
force-pushed
the
fix/teams-notes-page
branch
from
375cfb4 to
e7a49d1
Compare
Danyal-Faheem
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds dark-theme to notes and textbook page
Before
1.Notes Page
2.Textbook Page
After
1.Notes Page
2. Textbook page
[The white page of pdf is rendered via pdfViewer/Canvas. It cannot be converted to dark in dark-mode.]
