Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iam): add applications tab #13403

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Conversation

rjamet-ovh
Copy link
Contributor

@rjamet-ovh rjamet-ovh commented Oct 2, 2024

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #MANAGER-15410
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

IAM add applications tab

Related

  • CMT-18911

@rjamet-ovh rjamet-ovh marked this pull request as ready for review October 7, 2024 08:35
@rjamet-ovh rjamet-ovh requested a review from a team as a code owner October 7, 2024 08:35
JacquesLarique
JacquesLarique previously approved these changes Oct 8, 2024
oalkabouss
oalkabouss previously approved these changes Oct 9, 2024
@rjamet-ovh
Copy link
Contributor Author

Hello @zZHorizonZz

Thank you for your contribution!
We're currently in the process of testing the app and managing translations and tracking.

We'll update this PR as soon as we progress on theses steps.

@zZHorizonZz
Copy link
Contributor

@rjamet-ovh Hey, sorry for not responding to the reviews in #13396. Since I didn't create that pull request, I wasn't subscribed to it so I didn't get any notifications and was unaware that the review was happening there. From what I see, the main issue was with me adding English translations to the French files. I could have used a translator, but I don't know if they would be accurate with French, so I opted to keep the text in English.

zZHorizonZz and others added 3 commits November 20, 2024 10:55
ref: MANAGER-15410

Signed-off-by: Romain Jamet <[email protected]>
ref: MANAGER-15410

Signed-off-by: Romain Jamet <[email protected]>
Copy link

sonarqubecloud bot commented Dec 6, 2024

@tibs245 tibs245 mentioned this pull request Dec 13, 2024
7 tasks
@tibs245 tibs245 changed the base branch from develop to release/enabler-hpc-w51 December 13, 2024 09:54
@tibs245 tibs245 merged commit 301669d into release/enabler-hpc-w51 Dec 13, 2024
19 of 20 checks passed
@tibs245 tibs245 deleted the feat/MANAGER-15410 branch December 13, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants