Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 remove frame in chart animation #3811

Merged
merged 10 commits into from
Jan 8, 2025
Merged

Conversation

lucasrodes
Copy link
Member

@lucasrodes lucasrodes commented Jan 8, 2025

Animating Line Charts was causing a bug in the first frame, where it was being shown as a bar chart. Instead, for Line Charts we now skip the first frame.

Fixes #3812

@owidbot
Copy link
Contributor

owidbot commented Jan 8, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-bug-remove-frame-chart

chart-diff: ✅ No charts for review.
data-diff: ✅ No differences found
Legend: +New  ~Modified  -Removed  =Identical  Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet

Automatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included

Edited: 2025-01-08 17:37:03 UTC
Execution time: 19.56 seconds

@lucasrodes lucasrodes marked this pull request as ready for review January 8, 2025 23:39
@lucasrodes lucasrodes merged commit 3c34e8b into master Jan 8, 2025
10 checks passed
@lucasrodes lucasrodes deleted the bug-remove-frame-chart branch January 8, 2025 23:40
antea04 pushed a commit that referenced this pull request Feb 5, 2025
* ✨ add URL-query support in some wizard apps

* 🔨 Refactor ETL configuration to disable staging environment

* ✨ Add validation for URL query parameters in wizard component

* ✨ Enhance chart URL handling and query parameter extraction

* 🐛 remove frame in chart animation

* remove unnecessary write

* ✨ skip first frame in linecharts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: remove first frame in animation of line charts
2 participants