Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] adding test for listing permission of a folder in personal and project space with denied role enabled #10722

Merged
merged 1 commit into from
Dec 11, 2024
Merged

[tests-only][full-ci] adding test for listing permission of a folder in personal and project space with denied role enabled #10722

merged 1 commit into from
Dec 11, 2024

Conversation

nirajacharya2
Copy link
Contributor

@nirajacharya2 nirajacharya2 commented Dec 4, 2024 •
edited
Loading

Description

This PR adds test for listing permission of a folder when Denied role is enabled

added tests
this permission is only for folders.
related discussion:#10627 (comment)

Scenario: user lists permissions of a folder after enabling 'Denied' role
Scenario: user lists permissions of a folder inside a space after enabling 'Denied' role

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nirajacharya2 nirajacharya2 self-assigned this Dec 4, 2024
@nirajacharya2 nirajacharya2 mentioned this pull request Dec 4, 2024
Open
6 tasks
@nirajacharya2 nirajacharya2 force-pushed the list-permission-denied branch from ee3c042 to 51d9a20 Compare December 4, 2024 05:42
@nirajacharya2 nirajacharya2 changed the title [tests-only][full-ci] adding test for listing permission of a folder in personal and project space [tests-only][full-ci] adding test for listing permission of a folder in personal and project space with denied role enabled Dec 5, 2024
@nirajacharya2 nirajacharya2 force-pushed the list-permission-denied branch from 51d9a20 to 89baa04 Compare December 5, 2024 06:59
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nirajacharya2 nirajacharya2 marked this pull request as ready for review December 5, 2024 08:17
@nirajacharya2 nirajacharya2 requested a review from saw-jan December 6, 2024 08:56
saw-jan
saw-jan approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

S-Panta
S-Panta approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@S-Panta S-Panta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@S-Panta S-Panta merged commit 930f905 into master Dec 11, 2024
4 checks passed
@S-Panta S-Panta deleted the list-permission-denied branch December 11, 2024 03:38
ownclouders pushed a commit that referenced this pull request Dec 11, 2024
@S-Panta
Merge pull request #10722 from owncloud/list-permission-denied
65cc315 
[tests-only][full-ci] adding test for listing permission of a folder in personal and project space with denied role enabled
@PrajwolAmatya PrajwolAmatya mentioned this pull request Dec 13, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S-Panta S-Panta S-Panta approved these changes

@saw-jan saw-jan saw-jan approved these changes

@anon-pradip anon-pradip Awaiting requested review from anon-pradip

@prashant-gurung899 prashant-gurung899 Awaiting requested review from prashant-gurung899

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

Assignees

@nirajacharya2 nirajacharya2

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nirajacharya2 @saw-jan @S-Panta