Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(parser): faster lexing regexes #2542

Closed
wants to merge 9 commits into from

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Feb 29, 2024

WIP

@github-actions github-actions bot added the A-parser Area - Parser label Feb 29, 2024
Copy link

codspeed-hq bot commented Feb 29, 2024

CodSpeed Performance Report

Merging #2542 will not alter performance

Comparing 02-29-perf_parser_faster_lexing_regexes (daf1993) with 02-29-refactor_parser_byte_search_macro_evaluate_to_matched_byte (51e0e5c)

Summary

✅ 27 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 02-29-perf_parser_faster_lexing_regexes branch 2 times, most recently from 40e9fd0 to edd3109 Compare February 29, 2024 13:20
@github-actions github-actions bot added the A-ast Area - AST label Mar 1, 2024
@Boshen Boshen force-pushed the 02-29-refactor_parser_byte_search_macro_evaluate_to_matched_byte branch from 51e0e5c to 47e1a42 Compare March 1, 2024 13:23
Base automatically changed from 02-29-refactor_parser_byte_search_macro_evaluate_to_matched_byte to main March 1, 2024 13:28
@overlookmotel
Copy link
Contributor Author

Am closing this because it's not actually faster. I'll return to it when I'm next working on the lexer.

@Boshen Boshen deleted the 02-29-perf_parser_faster_lexing_regexes branch August 12, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST A-parser Area - Parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant