Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(parser): slice regex pattern in lexer #2556

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Feb 29, 2024

WIP

Copy link
Contributor Author

overlookmotel commented Feb 29, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

Copy link

codspeed-hq bot commented Feb 29, 2024

CodSpeed Performance Report

Merging #2556 will not alter performance

Comparing 02-29-refactor_parser_slice_regex_pattern_in_lexer (e99371a) with 02-29-perf_parser_faster_lexing_regexes (2017511)

Summary

✅ 27 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 02-29-perf_parser_faster_lexing_regexes branch from 379ff0d to d55a301 Compare February 29, 2024 23:20
@overlookmotel overlookmotel force-pushed the 02-29-perf_parser_faster_lexing_regexes branch from d55a301 to 2017511 Compare February 29, 2024 23:30
@overlookmotel overlookmotel force-pushed the 02-29-refactor_parser_slice_regex_pattern_in_lexer branch from 1f6a5cf to e99371a Compare February 29, 2024 23:31
@overlookmotel
Copy link
Contributor Author

This was intended to be faster, but it's not clear that it actually is, so closing. I may try again when I return to working on lexer.

@Boshen Boshen deleted the 02-29-refactor_parser_slice_regex_pattern_in_lexer branch August 12, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-parser Area - Parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant