Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(transformer/object-rest-spread): generate catch variable binding with correct SymbolFlags #7469

Merged
merged 1 commit into from
Nov 26, 2024
Merged

fix(transformer/object-rest-spread): generate catch variable binding with correct SymbolFlags #7469

merged 1 commit into from
Nov 26, 2024

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Nov 25, 2024

No description provided.

@Dunqing Dunqing mentioned this pull request Nov 25, 2024
Merged
@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Nov 25, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 25, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@Dunqing Dunqing mentioned this pull request Nov 25, 2024
Merged
@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-bug Category - Bug labels Nov 25, 2024
@Dunqing Dunqing force-pushed the 11-22-feat_traverse_support_automatically_variable_hoisting_during_generating_bindings branch from f0fd5d3 to ea274bc Compare November 25, 2024 11:09
@Dunqing Dunqing force-pushed the 11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags branch from 2941100 to db6c375 Compare November 25, 2024 11:09
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 25, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #7469 will not alter performance

Comparing 11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags (37842c1) with main (199076b)

Summary

✅ 30 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 11-22-feat_traverse_support_automatically_variable_hoisting_during_generating_bindings branch 2 times, most recently from 2d5d1d3 to 460f0d2 Compare November 25, 2024 13:05
@Dunqing Dunqing force-pushed the 11-22-feat_traverse_support_automatically_variable_hoisting_during_generating_bindings branch from 460f0d2 to 69da6fc Compare November 25, 2024 17:35
@Dunqing Dunqing force-pushed the 11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags branch from db6c375 to ad649f6 Compare November 25, 2024 17:35
@Dunqing Dunqing force-pushed the 11-22-feat_traverse_support_automatically_variable_hoisting_during_generating_bindings branch from 69da6fc to 8f9c3a4 Compare November 25, 2024 17:40
@Dunqing Dunqing force-pushed the 11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags branch from ad649f6 to 6fcacb4 Compare November 25, 2024 17:40
@Dunqing Dunqing force-pushed the 11-22-feat_traverse_support_automatically_variable_hoisting_during_generating_bindings branch from 8f9c3a4 to f193c49 Compare November 26, 2024 02:22
@Dunqing Dunqing force-pushed the 11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags branch 2 times, most recently from 8e53319 to bc8fff8 Compare November 26, 2024 03:45
@Dunqing Dunqing force-pushed the 11-22-feat_traverse_support_automatically_variable_hoisting_during_generating_bindings branch from f193c49 to 67e0d9c Compare November 26, 2024 03:49
@Dunqing Dunqing force-pushed the 11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags branch from bc8fff8 to 20fc793 Compare November 26, 2024 03:49
@Dunqing Dunqing force-pushed the 11-22-feat_traverse_support_automatically_variable_hoisting_during_generating_bindings branch from 67e0d9c to 2ee960a Compare November 26, 2024 05:52
@Dunqing Dunqing force-pushed the 11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags branch from 20fc793 to aeb9365 Compare November 26, 2024 05:52
@overlookmotel overlookmotel changed the base branch from 11-22-feat_traverse_support_automatically_variable_hoisting_during_generating_bindings to graphite-base/7469 November 26, 2024 11:18
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 26, 2024
@overlookmotel Graphite App
Copy link
Contributor

overlookmotel commented Nov 26, 2024 •
edited by graphite-app bot
Loading

Merge activity

  • Nov 26, 6:31 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 26, 6:31 AM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Nov 26, 6:31 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 26, 6:39 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 26, 6:59 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 26, 7:04 AM EST: A user merged this pull request with the Graphite merge queue.

@overlookmotel overlookmotel added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Nov 26, 2024
@overlookmotel
Copy link
Contributor

  • Nov 26, 6:39 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

It does meet the requirements. Get on with it Graphite!

@overlookmotel overlookmotel force-pushed the 11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags branch from aeb9365 to 9dd0532 Compare November 26, 2024 11:47
@overlookmotel overlookmotel changed the base branch from graphite-base/7469 to main November 26, 2024 11:47
@overlookmotel overlookmotel force-pushed the 11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags branch from 9dd0532 to 7969be2 Compare November 26, 2024 11:48
@overlookmotel
Copy link
Contributor

Have rebased on main. Hopefully that'll unblock Graphite.

@overlookmotel overlookmotel force-pushed the 11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags branch from 7969be2 to 37842c1 Compare November 26, 2024 11:59
@graphite-app graphite-app bot merged commit 37842c1 into main Nov 26, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags branch November 26, 2024 12:04
@oxc-bot oxc-bot mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overlookmotel overlookmotel overlookmotel approved these changes

Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-bug Category - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dunqing @overlookmotel