Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transformer/async-to-generator): correct the SymbolFlags of function id in module #7470

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Nov 25, 2024

No description provided.

Copy link

graphite-app bot commented Nov 25, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-bug Category - Bug labels Nov 25, 2024
@Dunqing Dunqing force-pushed the 11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags branch from 2941100 to db6c375 Compare November 25, 2024 11:09
@Dunqing Dunqing force-pushed the 11-25-fix_transformer_async-to-generator_correct_the_symbolflags_of_function_id_in_module branch from 2918ec6 to 7c17a75 Compare November 25, 2024 11:09
Copy link

codspeed-hq bot commented Nov 25, 2024

CodSpeed Performance Report

Merging #7470 will not alter performance

Comparing 11-25-fix_transformer_async-to-generator_correct_the_symbolflags_of_function_id_in_module (58a125f) with main (199076b)

Summary

✅ 30 untouched benchmarks

@Dunqing Dunqing force-pushed the 11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags branch from db6c375 to ad649f6 Compare November 25, 2024 17:35
@Dunqing Dunqing force-pushed the 11-25-fix_transformer_async-to-generator_correct_the_symbolflags_of_function_id_in_module branch from 7c17a75 to 33bc9a6 Compare November 25, 2024 17:35
@Dunqing Dunqing force-pushed the 11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags branch from ad649f6 to 6fcacb4 Compare November 25, 2024 17:40
@Dunqing Dunqing force-pushed the 11-25-fix_transformer_async-to-generator_correct_the_symbolflags_of_function_id_in_module branch from 33bc9a6 to aa4cd47 Compare November 25, 2024 17:41
@Dunqing Dunqing force-pushed the 11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags branch from 6fcacb4 to 8e53319 Compare November 26, 2024 02:23
@Dunqing Dunqing force-pushed the 11-25-fix_transformer_async-to-generator_correct_the_symbolflags_of_function_id_in_module branch 3 times, most recently from 1bff2bf to 72ec0b8 Compare November 26, 2024 02:49
@Dunqing Dunqing force-pushed the 11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags branch from 8e53319 to bc8fff8 Compare November 26, 2024 03:45
@Dunqing Dunqing force-pushed the 11-25-fix_transformer_async-to-generator_correct_the_symbolflags_of_function_id_in_module branch from 72ec0b8 to 714169f Compare November 26, 2024 03:45
@Dunqing Dunqing force-pushed the 11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags branch from bc8fff8 to 20fc793 Compare November 26, 2024 03:49
@Dunqing Dunqing force-pushed the 11-25-fix_transformer_async-to-generator_correct_the_symbolflags_of_function_id_in_module branch from 714169f to 7183138 Compare November 26, 2024 03:49
@Dunqing Dunqing force-pushed the 11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags branch from 20fc793 to aeb9365 Compare November 26, 2024 05:52
@Dunqing Dunqing force-pushed the 11-25-fix_transformer_async-to-generator_correct_the_symbolflags_of_function_id_in_module branch from 7183138 to 5c3fb58 Compare November 26, 2024 05:52
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 26, 2024
Copy link
Contributor

overlookmotel commented Nov 26, 2024

Merge activity

  • Nov 26, 6:44 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 26, 6:59 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 26, 7:06 AM EST: A user merged this pull request with the Graphite merge queue.

@overlookmotel overlookmotel force-pushed the 11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags branch 2 times, most recently from 9dd0532 to 7969be2 Compare November 26, 2024 11:48
@overlookmotel overlookmotel force-pushed the 11-25-fix_transformer_async-to-generator_correct_the_symbolflags_of_function_id_in_module branch from 5c3fb58 to b673764 Compare November 26, 2024 11:50
@overlookmotel overlookmotel force-pushed the 11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags branch from 7969be2 to 37842c1 Compare November 26, 2024 11:59
@overlookmotel overlookmotel force-pushed the 11-25-fix_transformer_async-to-generator_correct_the_symbolflags_of_function_id_in_module branch from b673764 to 58a125f Compare November 26, 2024 12:00
Base automatically changed from 11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags to main November 26, 2024 12:04
@graphite-app graphite-app bot merged commit 58a125f into main Nov 26, 2024
27 checks passed
@graphite-app graphite-app bot deleted the 11-25-fix_transformer_async-to-generator_correct_the_symbolflags_of_function_id_in_module branch November 26, 2024 12:06
@oxc-bot oxc-bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants