refactor(transformer/class-properties): move transform logic of callee of CallExpression to transform_private_field_callee
#7503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Dunqing
force-pushed
the
11-27-refactor_transformer_class-properties_move_transform_logic_of_callee_of_callexpression_to_transform_private_field_callee
branch
from
49cc2a4 to
96356dd
Compare
Dunqing
changed the title
callee of CallExpression to transform_private_field_calleecallee of CallExpression to transform_private_field_callee
github-actions
bot
added
the
C-cleanup
CodSpeed Performance ReportMerging #7503 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
11-27-refactor_transformer_class-properties_move_transform_logic_of_callee_of_callexpression_to_transform_private_field_callee
branch
2 times, most recently
from
efd6f3a to
f11f2a6
Compare
overlookmotel
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
I've pushed a commit to include output for static props in comments.
@Dunqing If you're happy with that, please merge.
Merge activity
|
|
I caused merge conflicts with one of my other PRs. I'll fix and merge. |
overlookmotel
force-pushed
the
11-27-refactor_transformer_class-properties_move_transform_logic_of_callee_of_callexpression_to_transform_private_field_callee
branch
from
f11f2a6 to
80b4cff
Compare
…ee` of `CallExpression` to `transform_private_field_callee` (#7503) This transform logic is also can be used to `tag` of `TaggedTemplateExpression`, so let's move it to a separate function.
overlookmotel
force-pushed
the
11-27-refactor_transformer_class-properties_move_transform_logic_of_callee_of_callexpression_to_transform_private_field_callee
branch
from
80b4cff to
968863b
Compare
graphite-app
bot
deleted the
11-27-refactor_transformer_class-properties_move_transform_logic_of_callee_of_callexpression_to_transform_private_field_callee
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This transform logic is also can be used to
tagofTaggedTemplateExpression, so let's move it to a separate function.