Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transformer/class-properties): support for transforming TaggedTemplateExpresssion #7504

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Nov 27, 2024

"object.#prop`xyz`" -> "_classPrivateFieldGet(_prop, object).bind(object)`xyz`"
"object.obj.#prop`xyz`" -> "_classPrivateFieldGet(_prop, _object$obj = object.obj).bind(_object$obj)`xyz`"

Copy link

graphite-app bot commented Nov 27, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request labels Nov 27, 2024
@Dunqing Dunqing force-pushed the 11-27-refactor_transformer_class-properties_move_transform_logic_of_callee_of_callexpression_to_transform_private_field_callee branch from 49cc2a4 to 96356dd Compare November 27, 2024 09:26
@Dunqing Dunqing force-pushed the 11-27-feat_transformer_class-properties_support_for_transforming_taggedtemplateexpresssion branch from b14c044 to d848950 Compare November 27, 2024 09:26
Copy link

codspeed-hq bot commented Nov 27, 2024

CodSpeed Performance Report

Merging #7504 will not alter performance

Comparing 11-27-feat_transformer_class-properties_support_for_transforming_taggedtemplateexpresssion (3539f56) with main (968863b)

Summary

✅ 30 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 11-27-refactor_transformer_class-properties_move_transform_logic_of_callee_of_callexpression_to_transform_private_field_callee branch from f10e57e to efd6f3a Compare November 27, 2024 10:28
@overlookmotel overlookmotel force-pushed the 11-27-feat_transformer_class-properties_support_for_transforming_taggedtemplateexpresssion branch 2 times, most recently from 8f48b54 to 328d777 Compare November 27, 2024 10:30
@overlookmotel overlookmotel force-pushed the 11-27-refactor_transformer_class-properties_move_transform_logic_of_callee_of_callexpression_to_transform_private_field_callee branch from efd6f3a to f11f2a6 Compare November 27, 2024 10:37
@overlookmotel overlookmotel force-pushed the 11-27-feat_transformer_class-properties_support_for_transforming_taggedtemplateexpresssion branch from 328d777 to 02a63a8 Compare November 27, 2024 10:45
Copy link
Contributor

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed 2 commits to:

  1. include output for static props in comments.
  2. set correct span on the template tag.

@Dunqing If you're happy with these, please merge.

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Nov 27, 2024
Copy link
Member Author

Dunqing commented Nov 27, 2024

Merge activity

  • Nov 27, 6:25 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 27, 6:25 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 27, 6:30 AM EST: The Graphite merge queue removed this pull request due to downstack failures on PR #7503.
  • Nov 27, 6:30 AM EST: The Graphite merge queue removed this pull request due to downstack failures on PR #7503.
  • Nov 27, 7:05 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 27, 7:05 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 27, 12:05 PM UTC: The merge label '0-merge' was removed. This PR will no longer be merged by the Graphite merge queue
  • Nov 27, 7:09 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 27, 7:21 AM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 27, 2024
@overlookmotel overlookmotel force-pushed the 11-27-refactor_transformer_class-properties_move_transform_logic_of_callee_of_callexpression_to_transform_private_field_callee branch from f11f2a6 to 80b4cff Compare November 27, 2024 12:02
@overlookmotel overlookmotel force-pushed the 11-27-feat_transformer_class-properties_support_for_transforming_taggedtemplateexpresssion branch from 02a63a8 to ee4f70e Compare November 27, 2024 12:04
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 27, 2024
@overlookmotel overlookmotel changed the base branch from 11-27-refactor_transformer_class-properties_move_transform_logic_of_callee_of_callexpression_to_transform_private_field_callee to graphite-base/7504 November 27, 2024 12:08
@graphite-app graphite-app bot changed the base branch from graphite-base/7504 to main November 27, 2024 12:14
…emplateExpresssion` (#7504)

```js
"object.#prop`xyz`" -> "_classPrivateFieldGet(_prop, object).bind(object)`xyz`"
"object.obj.#prop`xyz`" -> "_classPrivateFieldGet(_prop, _object$obj = object.obj).bind(_object$obj)`xyz`"
```
@overlookmotel overlookmotel force-pushed the 11-27-feat_transformer_class-properties_support_for_transforming_taggedtemplateexpresssion branch from ee4f70e to 3539f56 Compare November 27, 2024 12:15
@graphite-app graphite-app bot merged commit 3539f56 into main Nov 27, 2024
27 checks passed
@graphite-app graphite-app bot deleted the 11-27-feat_transformer_class-properties_support_for_transforming_taggedtemplateexpresssion branch November 27, 2024 12:21
@oxc-bot oxc-bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants