Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transformer/var-declarations): add insert_var_with_init method #7667

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Dec 5, 2024

part of #7668

Copy link

graphite-app bot commented Dec 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@Dunqing Dunqing changed the title feat(transformer/var-declaration): add insert_var_with_init method feat(transformer/var-declaration): add insert_var_with_init method Dec 5, 2024
@Dunqing Dunqing force-pushed the 12-05-refactor_transformer_use_var_declaration_create_var_methods branch from 173a5eb to f437658 Compare December 5, 2024 03:57
Copy link

codspeed-hq bot commented Dec 5, 2024

CodSpeed Performance Report

Merging #7667 will not alter performance

Comparing 12-05-feat_transformer_var-declaration_add_insert_var_with_init_method (e8518e9) with main (0ca10e2)

Summary

✅ 29 untouched benchmarks

@Dunqing Dunqing force-pushed the 12-05-feat_transformer_var-declaration_add_insert_var_with_init_method branch from 1124b35 to 1541969 Compare December 5, 2024 03:57
@Dunqing Dunqing changed the title feat(transformer/var-declaration): add insert_var_with_init method feat(transformer/var-declarations): add insert_var_with_init method Dec 5, 2024
@overlookmotel overlookmotel force-pushed the 12-05-refactor_transformer_use_var_declaration_create_var_methods branch from f437658 to 5e17bb8 Compare December 5, 2024 13:47
@overlookmotel overlookmotel force-pushed the 12-05-feat_transformer_var-declaration_add_insert_var_with_init_method branch from 1541969 to 0bd5333 Compare December 5, 2024 13:48
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Dec 5, 2024
Copy link
Contributor

overlookmotel commented Dec 5, 2024

Merge activity

  • Dec 5, 8:52 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 5, 8:57 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 5, 9:03 AM EST: The Graphite merge queue removed this pull request due to downstack failures on PR #7666.
  • Dec 5, 9:03 AM EST: The Graphite merge queue removed this pull request due to downstack failures on PR #7666.
  • Dec 5, 9:20 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 5, 9:34 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 5, 9:43 AM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 5, 2024
@Dunqing Dunqing force-pushed the 12-05-refactor_transformer_use_var_declaration_create_var_methods branch from 5e17bb8 to 7804ffe Compare December 5, 2024 14:20
@Dunqing Dunqing force-pushed the 12-05-feat_transformer_var-declaration_add_insert_var_with_init_method branch from 0bd5333 to d10496e Compare December 5, 2024 14:20
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Dec 5, 2024
@overlookmotel overlookmotel force-pushed the 12-05-refactor_transformer_use_var_declaration_create_var_methods branch from 7804ffe to a57067f Compare December 5, 2024 14:24
@overlookmotel overlookmotel force-pushed the 12-05-feat_transformer_var-declaration_add_insert_var_with_init_method branch from d10496e to eb0ba85 Compare December 5, 2024 14:24
@overlookmotel overlookmotel changed the base branch from 12-05-refactor_transformer_use_var_declaration_create_var_methods to graphite-base/7667 December 5, 2024 14:31
@graphite-app graphite-app bot changed the base branch from graphite-base/7667 to main December 5, 2024 14:37
@overlookmotel overlookmotel force-pushed the 12-05-feat_transformer_var-declaration_add_insert_var_with_init_method branch from eb0ba85 to e8518e9 Compare December 5, 2024 14:38
@graphite-app graphite-app bot merged commit e8518e9 into main Dec 5, 2024
24 checks passed
@graphite-app graphite-app bot deleted the 12-05-feat_transformer_var-declaration_add_insert_var_with_init_method branch December 5, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants