Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(transformer): rename VarDeclarationsStore methods #7682

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Dec 5, 2024

Follow-on after #7668. Rename create_var* methods to create_uid_var*.

Previous method name create_var might suggest that it creates a binding with the provided name. But actually it creates a UID with name based on the name provided.

Copy link

graphite-app bot commented Dec 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 5, 2024
@overlookmotel overlookmotel marked this pull request as ready for review December 5, 2024 14:32
Copy link

codspeed-hq bot commented Dec 5, 2024

CodSpeed Performance Report

Merging #7682 will not alter performance

Comparing 12-05-refactor_transformer_rename_vardeclarationsstore_methods (1925ddc) with main (583b36b)

Summary

✅ 29 untouched benchmarks

@overlookmotel overlookmotel changed the base branch from 12-05-refactor_var-declarations_remove_unnecessary_init_parameter_from_insert_var to graphite-base/7682 December 5, 2024 14:39
@overlookmotel overlookmotel force-pushed the 12-05-refactor_transformer_rename_vardeclarationsstore_methods branch from b4a5a2a to ea11c0b Compare December 5, 2024 14:46
@overlookmotel overlookmotel changed the base branch from graphite-base/7682 to main December 5, 2024 14:47
@overlookmotel overlookmotel force-pushed the 12-05-refactor_transformer_rename_vardeclarationsstore_methods branch from ea11c0b to 6326420 Compare December 5, 2024 14:47
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Dec 5, 2024
Copy link
Contributor Author

overlookmotel commented Dec 5, 2024

Merge activity

  • Dec 5, 10:08 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 5, 10:08 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 5, 10:14 AM EST: A user merged this pull request with the Graphite merge queue.

Follow-on after #7668. Rename `create_var*` methods to `create_uid_var*`.

Previous method name `create_var` might suggest that it creates a binding with the provided name. But actually it creates a UID with name *based on* the name provided.
@overlookmotel overlookmotel force-pushed the 12-05-refactor_transformer_rename_vardeclarationsstore_methods branch from 6326420 to 1925ddc Compare December 5, 2024 15:09
@graphite-app graphite-app bot merged commit 1925ddc into main Dec 5, 2024
24 checks passed
@graphite-app graphite-app bot deleted the 12-05-refactor_transformer_rename_vardeclarationsstore_methods branch December 5, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants