Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(transformer): enable class-properties plugin #7750

Draft
wants to merge 1 commit into
base: 12-26-feat_transformer_class-properties_transform_static_instance_accessor_methods
Choose a base branch
from
Draft

chore(transformer): enable class-properties plugin #7750

wants to merge 1 commit into from
+3 −10

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Dec 9, 2024 •
edited
Loading

This plugin is incomplete now, we use this PR to track haven't unsupported parts by manually triggering monitor-oxc.

@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Dec 9, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 9, 2024
@Dunqing
Copy link
Member Author

Dunqing commented Dec 9, 2024

https://github.com/oxc-project/monitor-oxc/actions/runs/12239674713

@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 9, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #7750 will not alter performance

Comparing 12-09-chore_transformer_enable_class-properties_plugin (f181688) with 12-26-feat_transformer_class-properties_transform_static_instance_accessor_methods (713db99)

Summary

✅ 29 untouched benchmarks

@Dunqing Dunqing force-pushed the 12-09-chore_transformer_enable_class-properties_plugin branch from 4e40a4e to 2da9cae Compare December 11, 2024 03:12
@Dunqing Dunqing changed the base branch from main to 12-11-fix_transformer_class-properties_panic_when_the_callee_or_member_is_parenthesisexpression_or_ts-syntax_expressions December 11, 2024 03:12
@Dunqing Dunqing mentioned this pull request Dec 11, 2024
Merged
@Dunqing
Copy link
Member Author

Dunqing commented Dec 11, 2024

https://github.com/oxc-project/monitor-oxc/actions/runs/12268946323

@Dunqing Dunqing force-pushed the 12-09-chore_transformer_enable_class-properties_plugin branch from 2da9cae to 952027e Compare December 11, 2024 07:35
@Dunqing Dunqing changed the base branch from 12-11-fix_transformer_class-properties_panic_when_the_callee_or_member_is_parenthesisexpression_or_ts-syntax_expressions to 12-11-fix_transformer_class-properties_unwrap_failed_when_private_field_expression_doesn_t_contain_optional_expression_in_chainexpression December 11, 2024 07:35
@Dunqing Dunqing mentioned this pull request Dec 11, 2024
Merged
@Dunqing Dunqing force-pushed the 12-09-chore_transformer_enable_class-properties_plugin branch from 952027e to 39c042c Compare December 11, 2024 07:38
@Dunqing
Copy link
Member Author

Dunqing commented Dec 11, 2024

https://github.com/oxc-project/monitor-oxc/actions/runs/12271863610

@Dunqing Dunqing force-pushed the 12-11-fix_transformer_class-properties_unwrap_failed_when_private_field_expression_doesn_t_contain_optional_expression_in_chainexpression branch from b2bfacf to bcb1ea8 Compare December 11, 2024 07:47
@Dunqing Dunqing force-pushed the 12-09-chore_transformer_enable_class-properties_plugin branch 2 times, most recently from 2337edb to d05b53f Compare December 11, 2024 08:09
@overlookmotel overlookmotel force-pushed the 12-11-fix_transformer_class-properties_unwrap_failed_when_private_field_expression_doesn_t_contain_optional_expression_in_chainexpression branch 2 times, most recently from 6613461 to 4e479cb Compare December 11, 2024 11:20
@overlookmotel overlookmotel force-pushed the 12-09-chore_transformer_enable_class-properties_plugin branch from d05b53f to e23abdf Compare December 11, 2024 11:20
@overlookmotel overlookmotel changed the base branch from 12-11-fix_transformer_class-properties_unwrap_failed_when_private_field_expression_doesn_t_contain_optional_expression_in_chainexpression to graphite-base/7750 December 11, 2024 11:32
@overlookmotel overlookmotel force-pushed the 12-09-chore_transformer_enable_class-properties_plugin branch from e23abdf to 0cf4d99 Compare December 11, 2024 11:36
@overlookmotel overlookmotel changed the base branch from graphite-base/7750 to main December 11, 2024 11:37
@overlookmotel overlookmotel force-pushed the 12-09-chore_transformer_enable_class-properties_plugin branch from 0cf4d99 to d5aec18 Compare December 11, 2024 11:37
@Dunqing Dunqing force-pushed the 12-09-chore_transformer_enable_class-properties_plugin branch from d5aec18 to 15c0218 Compare December 13, 2024 03:08
@overlookmotel overlookmotel force-pushed the 12-09-chore_transformer_enable_class-properties_plugin branch from 15c0218 to f545650 Compare December 15, 2024 11:22
@overlookmotel
Copy link
Contributor

https://github.com/oxc-project/monitor-oxc/actions/runs/12338396809

@overlookmotel overlookmotel force-pushed the 12-09-chore_transformer_enable_class-properties_plugin branch from f545650 to 6f2ca00 Compare December 19, 2024 01:51
@overlookmotel overlookmotel changed the base branch from 12-20-refactor_transformer_class-properties_do_not_recreate_private_field_if_not_transforming_it to 12-20-fix_transformer_class-properties_unwrap_parenthesised_expressions December 20, 2024 15:03
This was referenced Dec 20, 2024
Merged
Merged
@overlookmotel overlookmotel force-pushed the 12-09-chore_transformer_enable_class-properties_plugin branch 3 times, most recently from 51e9a0b to efeeb24 Compare December 20, 2024 15:55
@overlookmotel
Copy link
Contributor

https://github.com/oxc-project/monitor-oxc/actions/runs/12434465731

@overlookmotel overlookmotel mentioned this pull request Dec 20, 2024
Open
@graphite-app graphite-app bot force-pushed the 12-20-fix_transformer_class-properties_unwrap_parenthesised_expressions branch from c46793e to 3057686 Compare December 23, 2024 03:46
Base automatically changed from 12-20-fix_transformer_class-properties_unwrap_parenthesised_expressions to main December 23, 2024 04:04
@github-actions github-actions bot added the A-ast Area - AST label Dec 23, 2024
@Dunqing Dunqing force-pushed the 12-09-chore_transformer_enable_class-properties_plugin branch 2 times, most recently from d1c95d6 to 3acd63e Compare December 28, 2024 09:08
@Dunqing Dunqing changed the base branch from main to 12-26-feat_transformer_class-properties_transform_static_instance_accessor_methods December 28, 2024 09:08
This was referenced Dec 28, 2024
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
@Dunqing
Copy link
Member Author

Dunqing commented Dec 28, 2024

https://github.com/oxc-project/monitor-oxc/actions/runs/12525387408

@Dunqing Dunqing force-pushed the 12-26-feat_transformer_class-properties_transform_static_instance_accessor_methods branch from dee1d70 to a66fdb0 Compare December 28, 2024 13:43
@Dunqing Dunqing force-pushed the 12-26-feat_transformer_class-properties_transform_static_instance_accessor_methods branch from a66fdb0 to 713db99 Compare December 28, 2024 16:18
@Dunqing Dunqing force-pushed the 12-09-chore_transformer_enable_class-properties_plugin branch from 3acd63e to f181688 Compare December 28, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel will be requested when the pull request is marked ready for review overlookmotel is a code owner

Assignees
No one assigned
Labels
A-ast Area - AST A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dunqing @overlookmotel