Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transform-conformance): support enabling all class-related plugins when any of them are enabled in update_fixtures #8200

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Dec 31, 2024

The class-properties plugin supports all class-related plugins, so we need to ensure that once any of them are enabled, we also enable all class-related plugins.

Copy link
Member Author

Dunqing commented Dec 31, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request labels Dec 31, 2024
@Dunqing Dunqing force-pushed the 12-26-feat_transformer_class-properties_transform_static_instance_accessor_methods branch from 55464b6 to 211e9a7 Compare December 31, 2024 10:34
@Dunqing Dunqing force-pushed the 12-31-feat_transform-conformance_support_enabling_all_class-related_plugins_when_any_of_them_are_enabled_in_update_fixtures branch from 2bbef3b to 1fcc363 Compare December 31, 2024 10:34
@Dunqing Dunqing force-pushed the 12-26-feat_transformer_class-properties_transform_static_instance_accessor_methods branch from 211e9a7 to b1ab06c Compare December 31, 2024 10:49
@Dunqing Dunqing force-pushed the 12-31-feat_transform-conformance_support_enabling_all_class-related_plugins_when_any_of_them_are_enabled_in_update_fixtures branch from 1fcc363 to 81a5e20 Compare December 31, 2024 10:49
@Dunqing Dunqing force-pushed the 12-26-feat_transformer_class-properties_transform_static_instance_accessor_methods branch from b1ab06c to e06d6fb Compare December 31, 2024 11:03
@Dunqing Dunqing force-pushed the 12-31-feat_transform-conformance_support_enabling_all_class-related_plugins_when_any_of_them_are_enabled_in_update_fixtures branch from 81a5e20 to 745b3a6 Compare December 31, 2024 11:03
@Dunqing Dunqing marked this pull request as ready for review December 31, 2024 12:21
@Dunqing Dunqing marked this pull request as draft December 31, 2024 12:22
@Dunqing Dunqing marked this pull request as ready for review December 31, 2024 12:24
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 31, 2024
Copy link

graphite-app bot commented Dec 31, 2024

Merge activity

…ns when any of them are enabled in update_fixtures (#8200)

The `class-properties` plugin supports all class-related plugins, so we need to ensure that once any of them are enabled, we also enable all class-related plugins.
@Dunqing Dunqing force-pushed the 12-26-feat_transformer_class-properties_transform_static_instance_accessor_methods branch from e06d6fb to ad77ad5 Compare December 31, 2024 12:36
@Dunqing Dunqing force-pushed the 12-31-feat_transform-conformance_support_enabling_all_class-related_plugins_when_any_of_them_are_enabled_in_update_fixtures branch from 745b3a6 to 3c77ed1 Compare December 31, 2024 12:37
Base automatically changed from 12-26-feat_transformer_class-properties_transform_static_instance_accessor_methods to main December 31, 2024 13:30
@graphite-app graphite-app bot merged commit 3c77ed1 into main Dec 31, 2024
20 checks passed
@graphite-app graphite-app bot deleted the 12-31-feat_transform-conformance_support_enabling_all_class-related_plugins_when_any_of_them_are_enabled_in_update_fixtures branch December 31, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant