fix(transformer/class-properties): replace `this` and class name in static blocks #8035

overlookmotel · 2024-12-20T03:08:26Z

Transform this, class name, and super in static blocks.

overlookmotel · 2024-12-20T03:08:50Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2024-12-20T03:38:57Z

CodSpeed Performance Report

Merging #8035 will degrade performances by 11.32%

_{Comparing 12-20-fix_transformer_class-properties_replace_this_and_class_name_in_static_blocks (043252d) with main (6b6444b)}

Summary

❌ 3 regressions
✅ 26 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	`main`	`12-20-fix_transformer_class-properties_replace_this_and_class_name_in_static_blocks`	Change
❌	`transformer[antd.js]`	50 ms	55.2 ms	-9.52%
❌	`transformer[checker.ts]`	21.6 ms	24.3 ms	-11.32%
❌	`transformer[pdf.mjs]`	9.3 ms	10.3 ms	-9.78%

graphite-app · 2024-12-20T10:06:56Z

Merge activity

Dec 20, 5:06 AM EST: A user added this pull request to the Graphite merge queue.
Dec 20, 5:14 AM EST: A user merged this pull request with the Graphite merge queue.

…tatic blocks (#8035) Transform `this`, class name, and `super` in static blocks.

## [0.43.0] - 2024-12-21 - de4c772 traverse: [**BREAKING**] Rename `Ancestor::is_via_*` methods to `is_parent_of_*` (#8031) (overlookmotel) - ed75e42 semantic: [**BREAKING**] Make SymbolTable fields `pub(crate)` instead of `pub` (#7999) (Boshen) ### Features - 75b775c allocator: `Vec<u8>::into_string` (#8017) (overlookmotel) - 8547e02 ast: Implement `allocator_api2` for `Allocator` (#8043) (Boshen) - 63a95e4 ast: Add `AstBulder::move_property_key` (#7998) (overlookmotel) - 897a1a8 transformer/class-properties: Exit faster from super replacement visitor (#8028) (overlookmotel) - 3ea4109 transformer/class-properties: Transform super update expressions within static prop initializer (#7997) (Dunqing) - cc57db3 transformer/class-properties: Transform super assignment expressions within static prop initializer (#7991) (Dunqing) - 6b6444b traverse: Record current block scope (#8007) (overlookmotel) ### Bug Fixes - 043252d transformer/class-properties: Replace `this` and class name in static blocks (#8035) (overlookmotel) - 273795d transformer/class-properties: Run other transforms on static properties, static blocks, and computed keys (#7982) (overlookmotel) ### Performance - c0dd3f8 ast: `move_expression` and `move_statement` produce dummy with no span (#7995) (overlookmotel) - 862838f codegen: Remove useless to_owned (#8014) (Dunqing) - 2736657 semantic: Allocate `UnresolvedReferences` in allocator (#8046) (Boshen) - 2e8872c semantic: Allocate child scope in allocator (#8045) (Boshen) - 414e828 semantic: Allocate symbol data in Allocator (#8012) (Boshen) - 7aebed0 semantic: Allocate `Bindings` in allocator (#8021) (Boshen) - 0f9308f transformer/react-refresh: Reduce allocations (#8018) (overlookmotel) - 0deb9e6 transformer/react-refresh: Reserve capacity in hook key string (#8016) (overlookmotel) - 7b70347 transformer/react-refresh: Avoid allocating string in each hook call (#8013) (Dunqing) ### Documentation - df5c341 ast: Improve docs for `AstBuilder::move_*` methods (#7994) (overlookmotel) ### Refactor - f1adf9f semantic: `ScopeTree::rename_binding` remove old binding first (#8020) (overlookmotel) - 02f968d semantic: Change `Bindings` to a plain `FxHashMap` (#8019) (Boshen) - e7476a1 semantic: Remove `serialize` (#8015) (Boshen) - 1cf7b83 semantic: Simplify handling namespace stack (#7987) (Dunqing) - 48cb52b semantic: Remove resetting `current_reference_flags` in visit functions (#7986) (Dunqing) - 3250a47 semantic: Remove unused current_symbol_flags (#7985) (Dunqing) - efe96ec semantic: Use `Stack` for function stack node ids (#7984) (Dunqing) - ac097e9 transformer/class-properties: Rename file (#8036) (overlookmotel) - 059a5dd transformer/class-properties: Do not pass `ScopeId` into `insert_instance_inits` (#8001) (overlookmotel) - 0a38eea transformer/class-properties: Use `temp_var_name_base` to generate temp var names for `super` transform (#8004) (overlookmotel) - d1b7181 transformer/class-properties: Rename var (#8006) (overlookmotel) - 5a23d72 transformer/class-properties: Remove outdated comment (#8000) (overlookmotel) - b3a5f3e transformer/class-properties: Mark `transform_assignment_expression_if_super_member_assignment_target` as inline (#7993) (Dunqing) ### Testing - bcb33c0 semantic: Add a test for catch parameters reference (#7988) (Dunqing) Co-authored-by: Boshen <[email protected]>

This was referenced Dec 20, 2024

chore(transformer): enable class-properties plugin #7750

Draft

fix(transformer/class-properties): run other transforms on static properties, static blocks, and computed keys #7982

Merged

github-actions bot added the A-transformer Area - Transformer / Transpiler label Dec 20, 2024

overlookmotel mentioned this pull request Dec 20, 2024

perf(ast): move_expression and move_statement produce dummy with no span #7995

Merged

github-actions bot added the C-bug Category - Bug label Dec 20, 2024

overlookmotel marked this pull request as ready for review December 20, 2024 03:08

overlookmotel requested a review from Dunqing as a code owner December 20, 2024 03:08

overlookmotel mentioned this pull request Dec 20, 2024

Remaining problems for class properties transform #7730

Open

17 tasks

overlookmotel force-pushed the 12-18-refactor_transformer_class-properties_transform_class_in_2_phases branch from 3913f9f to 3cb7ed5 Compare December 20, 2024 03:13

overlookmotel force-pushed the 12-20-fix_transformer_class-properties_replace_this_and_class_name_in_static_blocks branch from eaa9128 to 4410da9 Compare December 20, 2024 03:13

overlookmotel mentioned this pull request Dec 20, 2024

refactor(transformer/class-properties): rename file #8036

Merged

Dunqing force-pushed the 12-18-refactor_transformer_class-properties_transform_class_in_2_phases branch from 3cb7ed5 to 75c91ea Compare December 20, 2024 03:42

graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 20, 2024

Dunqing force-pushed the 12-20-fix_transformer_class-properties_replace_this_and_class_name_in_static_blocks branch from 4410da9 to 0f25091 Compare December 20, 2024 03:42

Dunqing force-pushed the 12-18-refactor_transformer_class-properties_transform_class_in_2_phases branch 2 times, most recently from f6aec27 to 808956a Compare December 20, 2024 04:00

Dunqing force-pushed the 12-20-fix_transformer_class-properties_replace_this_and_class_name_in_static_blocks branch from 0f25091 to 34c7c30 Compare December 20, 2024 04:00

fix(transformer/class-properties): replace this and class name in s…

043252d

…tatic blocks (#8035) Transform `this`, class name, and `super` in static blocks.

Dunqing force-pushed the 12-18-refactor_transformer_class-properties_transform_class_in_2_phases branch from 808956a to 273795d Compare December 20, 2024 10:07

Dunqing force-pushed the 12-20-fix_transformer_class-properties_replace_this_and_class_name_in_static_blocks branch from 34c7c30 to 043252d Compare December 20, 2024 10:08

Base automatically changed from 12-18-refactor_transformer_class-properties_transform_class_in_2_phases to main December 20, 2024 10:11

graphite-app bot merged commit 043252d into main Dec 20, 2024
27 checks passed

graphite-app bot deleted the 12-20-fix_transformer_class-properties_replace_this_and_class_name_in_static_blocks branch December 20, 2024 10:14

oxc-bot mentioned this pull request Dec 21, 2024

release(crates): v0.43.0 #8054

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(transformer/class-properties): replace `this` and class name in static blocks #8035

fix(transformer/class-properties): replace `this` and class name in static blocks #8035

overlookmotel commented Dec 20, 2024 •

edited

Loading

overlookmotel commented Dec 20, 2024 •

edited

Loading

codspeed-hq bot commented Dec 20, 2024 •

edited

Loading

graphite-app bot commented Dec 20, 2024 •

edited

Loading

fix(transformer/class-properties): replace this and class name in static blocks #8035

fix(transformer/class-properties): replace this and class name in static blocks #8035

Conversation

overlookmotel commented Dec 20, 2024 • edited Loading

overlookmotel commented Dec 20, 2024 • edited Loading

How to use the Graphite Merge Queue

codspeed-hq bot commented Dec 20, 2024 • edited Loading

CodSpeed Performance Report

Merging #8035 will degrade performances by 11.32%

Summary

Benchmarks breakdown

graphite-app bot commented Dec 20, 2024 • edited Loading

Merge activity

fix(transformer/class-properties): replace `this` and class name in static blocks #8035

fix(transformer/class-properties): replace `this` and class name in static blocks #8035

overlookmotel commented Dec 20, 2024 •

edited

Loading

overlookmotel commented Dec 20, 2024 •

edited

Loading

codspeed-hq bot commented Dec 20, 2024 •

edited

Loading

graphite-app bot commented Dec 20, 2024 •

edited

Loading