Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(minifier): minify string PropertyKey #8147

Merged
merged 1 commit into from
Dec 27, 2024
Merged

feat(minifier): minify string PropertyKey #8147

merged 1 commit into from
Dec 27, 2024
+56 −9

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Dec 27, 2024

No description provided.

@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Dec 27, 2024
@Boshen Graphite App
Copy link
Member Author

Boshen commented Dec 27, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 27, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #8147 will not alter performance

Comparing 12-27-feat_minifier_minify_string_propertykey_ (8fb71f5) with main (79af100)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen force-pushed the 12-27-feat_minifier_minify_string_propertykey_ branch from 476501b to 93e97ca Compare December 27, 2024 15:04
@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 27, 2024 •
edited
Loading

Merge activity

@Boshen Boshen force-pushed the 12-27-feat_minifier_minify_string_propertykey_ branch from 93e97ca to 8fb71f5 Compare December 27, 2024 15:09
@graphite-app graphite-app bot merged commit 8fb71f5 into main Dec 27, 2024
25 checks passed
@graphite-app graphite-app bot deleted the 12-27-feat_minifier_minify_string_propertykey_ branch December 27, 2024 15:14
This was referenced Dec 28, 2024
Closed
Merged
Boshen pushed a commit that referenced this pull request Dec 29, 2024
@sapphi-red
fix(minifier): minify string PropertyKey (#8177)
75d5f17 
#8169 added `if self.in_fixed_loop` in `try_compress_property_key`. Because `exit_property_key` was not called for `PeepholeOptimizations`, `try_compress_property_key` was never called.

refs #8147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-minifier Area - Minifier C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Boshen