fix(editor/vscode): set minimum supported ver. to ^1.93.0

[pashokitsme]

Hi,

I'm using Cursor which is based on VSCode 1.93 at the moment of this PR. And i've faced with an issue when i can't install latest version of oxc vscode plugin - by default plugin marketplace offers me v0.0.1 and via Install Specific Version i can install only v0.10.3 while latest is v0.15.3. No idea when Cursor will update its version.
There's no issue with VSCode, only Cursor.

After downgrading minimum version, Cursor allowed me to install plugin that i compiled by myself, everything seem to be working.

Not sure about how is usually contributions made here so correct me if i miss something

[graphite-app]

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

[Sysix]

@nrayburn-tech 1.93 is released in August 2024.
Only supporting the latest version does not sounds right. What do you think?
In my company, we do not get always the lastest update for vscode immediately.

@pashokitsme thanks for the fix and the details why this is needed.
Can you tell renovate to ignore this npm package?

I searched the documentation for you:
https://docs.renovatebot.com/configuration-options/#ignoredeps

[nrayburn-tech]

Unless there’s a reason for the Oxc plugin to target a more recent version, I wouldn’t update it as a general rule. That being said, to avoid supporting really old versions we could target the current version minus 6 to only support 6 months worth of VS Code releases ( 6 just being an example, we could pick whatever).

So, targeting an older version is probably fine so long as it’s not ancient. I don’t have any concerns with this change.

Something to consider when targeting an older version is you might want to run tests against the old version and the latest version to ensure you are compatible with new releases as they come out.

[camc314]

we could target the current version minus 6 to only support 6 months worth of VS Code releases ( 6 just being an example, we could pick whatever).

👍 this seems reasonable

[pashokitsme]

target the current version minus 6 to only support 6 months

Don't really know how to configure renovate like this. Something like?:

"packageRules": [
  {
    "matchPackagePatterns": ["@types/vscode"],
    "minimumReleaseAge": "6 months"
  }
]

And will renovate update not only devDependencies, but version in engines too? Feels like it won't

[camc314]

Based on the docs that looks correct.

As for keeping engines in sync

"packageRules": [
  {
    "matchPackagePatterns": ["@types/vscode"],
    "minimumReleaseAge": "6 months",
    "postUpgradeTasks": {
        "commands": [
          "jq '.engines.vscode = \"^\" + (.dependencies.vscode | ltrimstr(\"^\"))' package.json > tmp.json && mv tmp.json package.json"
        ],
        "fileFilters": ["package.json"]
    }
  }
]

didn't test this, but chat gpt suggests this?

But actually, perhaps we want to keep @types/vscode up to date, and simply specify an older supported version in engines?

[Sysix]

But actually, perhaps we want to keep @types/vscode up to date, and simply specify an older supported version in engines?

The build will fail because it detects different versions.

Don't really know how to configure renovate like this.

I do not think you need to fix this in this PR.

[nrayburn-tech]

I would suggest downgrade the version here. Configure renovate to ignore it for now.

Once somebody can test how to get it working correctly (update to the 6 month old version and keep engines in sync) that can be a separate PR. From the docs, I do think something like @camc314 shared should work but I don’t have experience with Renovate.

This isn’t really a critical package to keep up to date for vulnerabilities or things of that nature, so I think it’s low risk to ignore for now.

[pashokitsme]

Let's merge it then

[camc314]

lock file needs updating

[pashokitsme]

Oops. Didn't noticed. Fixed