[WIP] Only Send Updates When Formatting Changed #1188
Draft
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarcaur
changed the title
bmarcaur
commented
Jan 9, 2025
|
|
||
| // The Javadoc of this API says that you should set it to null when the document is unchanged | ||
| // We should not be trying to format a document that is already formatted | ||
| if (preFormatText.equals(formattedText)) { |
There was a problem hiding this comment.
There was a problem hiding this comment.
In this case, does getFormatReplacements return an empty list?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Every format action caused the current buffer to be marked as modified.
After this PR
This was due to us updating the text on every format even if it was unchanged. Now it only updates when something was formatted.
Way more context than you could ever want: https://youtrack.jetbrains.com/issue/IJPL-162382