Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Only Send Updates When Formatting Changed #1188

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

[WIP] Only Send Updates When Formatting Changed #1188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion ...n/src/main/java/com/palantir/javaformat/intellij/PalantirJavaFormatFormattingService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,21 @@ public void run() {
return;
}

String preFormatText = request.getDocumentText();

try {
String formattedText = applyReplacements(
request.getDocumentText(),
formatterService.get().getFormatReplacements(request.getDocumentText(), toRanges(request)));
request.onTextReady(formattedText);

// The Javadoc of this API says that you should set it to null when the document is unchanged
// We should not be trying to format a document that is already formatted
if (preFormatText.equals(formattedText)) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leveraging https://github.com/JetBrains/intellij-community/blob/9bcc90a5987ed7ac54336535e2dfa16eaddb0a3e/platform/code-style-api/src/com/intellij/formatting/service/AsyncFormattingRequest.java#L62 to dirty the buffer less

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, does getFormatReplacements return an empty list?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh, shoot I broke down my debug setup. Let me turn it back on

request.onTextReady(null);
} else {
request.onTextReady(formattedText);
}

} catch (FormatterException e) {
request.onError(
Notifications.PARSING_ERROR_TITLE,
Expand Down
Loading