Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meta yaml schema #134

Closed
wants to merge 9 commits into from
Closed

Add meta yaml schema #134

wants to merge 9 commits into from

Conversation

cisaacstern
Copy link
Member

@cisaacstern cisaacstern commented Nov 16, 2023

Closes #93
Towards #84

To start, this is just a copy of the contents of https://github.com/pangeo-forge/meta-yaml-schema.

I will make adjustments before merging, namely:

  • Don't require Pydantic dependency
  • Provide minimal schema option which excludes provenance (and only has recipe object section)
  • Update extended schema to reflect current provenance
  • Provide optional validation of meta-yamls (maybe push to future PR, non-essential)

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (005951c) 96.11% compared to head (089bcc2) 96.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
+ Coverage   96.11%   96.46%   +0.35%     
==========================================
  Files          14       15       +1     
  Lines         463      509      +46     
==========================================
+ Hits          445      491      +46     
  Misses         18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cisaacstern cisaacstern self-assigned this Nov 16, 2023
@cisaacstern
Copy link
Member Author

Converting this to a draft as I am going to shift effort towards #137 as a first pass at this concept with a much lighter footprint. Leaving this open for further discussion at a later date.

@cisaacstern
Copy link
Member Author

Turns out #137 is a nearly direct replacement for this, but in traitlets! So closing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move meta-yaml-schema into pangeo-forge-runner
1 participant