Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta.yaml schema (implemented with traitlets!) #137

Merged
merged 11 commits into from
Nov 17, 2023
Merged

Conversation

cisaacstern
Copy link
Member

@cisaacstern cisaacstern commented Nov 17, 2023

A much lighter version of #134 as a starting place.

As I got into this, I realized we didn't need to sacrifice much of #134 after all, because almost everything there can be done with pure traitlets, saving us the Pydantic dependency!

@cisaacstern cisaacstern mentioned this pull request Nov 17, 2023
4 tasks
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (005951c) 96.11% compared to head (e6cefce) 96.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
- Coverage   96.11%   96.09%   -0.03%     
==========================================
  Files          14       15       +1     
  Lines         463      486      +23     
==========================================
+ Hits          445      467      +22     
- Misses         18       19       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cisaacstern cisaacstern changed the title Minimal meta.yaml schema Meta.yaml schema (implemented with traitlets!) Nov 17, 2023
@cisaacstern cisaacstern added test-flink Add this label to PRs to trigger Dataflow integration test. test-dataflow Add this label to PRs to trigger Dataflow integration test. labels Nov 17, 2023
@cisaacstern
Copy link
Member Author

@jbusecke are in the final 2 hrs of our hack week here in LA, and I need this PR to finish the work I'm targeting to complete for him! The only failing check here is -0.03% on coverage:

Screen Shot 2023-11-17 at 2 40 34 PM

Which I think is close enough! Everthing else passes and AFAICT (🤞 🤞 🤞 ) the public API is totally unchanged.

@ranchodeluxe and @yuvipanda please forgive me if this is too rash! I beg forgiveness to the PR review gods and generally don't endorse unreviewed merges! But the hack week goals are calling...

To be clear, I totally 100% encourage follow-on Issues/PRs if there are things here anyone doesn't like, and with that, I'll merge!

@cisaacstern cisaacstern merged commit 1c6178f into main Nov 17, 2023
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-dataflow Add this label to PRs to trigger Dataflow integration test. test-flink Add this label to PRs to trigger Dataflow integration test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant