-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Boxed Variant interface & Boxed Ion implementation #540
Conversation
223e471
to
b20a428
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (61.32%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #540 +/- ##
==========================================
- Coverage 81.17% 80.49% -0.68%
==========================================
Files 90 95 +5
Lines 19727 20266 +539
Branches 19727 20266 +539
==========================================
+ Hits 16014 16314 +300
- Misses 3293 3520 +227
- Partials 420 432 +12 ☔ View full report in Codecov by Sentry. |
Conformance comparison report
Number passing in both: 5511 Number failing in both: 838 Number passing in Base (2a3dd4b) but now fail: 80 Number failing in Base (2a3dd4b) but now pass: 0 Click here to see
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One follow-up about the already lowered value. Otherwise initial boxed Ion variant impl looks good.
7f79f58
to
6535718
Compare
This PR roughs in boxed variants and an implementation of ion values that uses the boxed variant interface.
There are still
todo
s and some additional test failures that will be addressed by future PRs that add functionality.Of note, that there are expected to be ~80 new conformance test failures that will eventually be fixed as well as passing an additional ~12 conformance tests after all features from #536 are incorporated.
To see the ultimate end-point of this integration, refer to #536 and note the test coverage and conformance test results.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.