Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed headers cannot be passed by reference error, fixes #46 #47

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tadaszelvys
Copy link

No description provided.

@tadaszelvys tadaszelvys changed the title Fixed headers cannot be passed by reference error #43 Fixed headers cannot be passed by reference error, fixes #43 Jun 14, 2023
@tadaszelvys tadaszelvys changed the title Fixed headers cannot be passed by reference error, fixes #43 Fixed headers cannot be passed by reference error, fixes #46 Jun 14, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #47 (f75fcaa) into main (561ae0f) will decrease coverage by 0.61%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##                main      #47      +/-   ##
=============================================
- Coverage     100.00%   99.39%   -0.61%     
  Complexity        61       61              
=============================================
  Files              3        3              
  Lines            156      165       +9     
=============================================
+ Hits             156      164       +8     
- Misses             0        1       +1     
Impacted Files Coverage Δ
src/Token/AppleAccessToken.php 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@nunoperalta
Copy link

Shouldn't it be:

 $s = (object) ["alg" => 'RS256'];
 $decoded = JWT::decode($options['id_token'], $key, $s);

(passing RS256)

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants