Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a -progress option to display the progress during elimination #42

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

t-oster
Copy link

@t-oster t-oster commented Jan 6, 2020

Hi,
I like this utility, because it helps to fix my messed up foto library.
However since I have a few ten-thousand files, it takes some time and I miss a progress indicator, so I added one.
In order to not break any existing script it is disabled by default and has to be enabled by the -progress true command line switch.
I am not a C++ developer, but I hope it is clean.
Please review and let me know what you think.

@t-oster t-oster force-pushed the feature-progress branch 5 times, most recently from 5d964f5 to 0edeedc Compare January 7, 2020 07:04
@jasontitus
Copy link

This would definitely be a great thing to add. I'm 6 days into a rdfind run (over about 25TB of substantially duplicated old backups) and have no idea if I have one more day or another week. Especially on the final sha1 run. I watch the lsof output to see where it is, but it doesn't have any recognizable pattern - it is hopping around through various top level directories and such.

@jasontitus
Copy link

Running now with this branch. One suggestion - right now it doesn't update the progress until it gets to 1% so you don't know if it is going to show up until it gets there. On a process that takes days, 1% can actually take a while to get to. Could it set '0%' at the beginning or show higher granularity?

@t-oster
Copy link
Author

t-oster commented Jan 21, 2020

Of cause, i could easily go to let's say two places behind the dot.

@t-oster
Copy link
Author

t-oster commented Jan 21, 2020

@jasontitus better with 92d3b0d?

@t-oster
Copy link
Author

t-oster commented Jan 29, 2020

@pauldreik I don't want to be rude, but can you estimate when you have time to review?

@sabjorn
Copy link

sabjorn commented Apr 4, 2020

@jasontitus bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants