Add code coverage to CI with Coveralls integration #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade github checkout and rust-cache actions to latest versions and add names to each step where missing. Also move rust-cache step to happen after the toolchain is installed, as recommended by https://github.com/Swatinem/rust-cache?tab=readme-ov-file#example-usage.
actions-rs is no longer maintained and rust-bitcoin is using dtolnay/rust-toolchain in their CI.
Following rust-bitcoin's example, run code coverage in CI with cargo llvm-cov and upload the results to Coveralls.
spacebear21
force-pushed
the
code-coverage-ci
branch
from
bd94b57 to
9766e39
Compare
|
Coverage report for this PR can be found here: https://coveralls.io/jobs/155930549. |
|
It may be useful to enable coveralls PR comments if we feel comfortable with giving their bot write access to the repo. FWIW rust-bitcoin does this. |
DanGould
approved these changes
Nov 12, 2024
I did and they do! You can see that it restores the cache in the "Use Cache" step and that the dependencies are fresh instead of re-downloaded/re-compiled: https://github.com/payjoin/rust-payjoin/actions/runs/11791047279/job/32842477162?pr=385. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the github actions up-to-date with latest versions and adds more descriptive names to the workflow steps.
It also swaps the ordering of
rust-cacheand the rust toolchain installation steps so that cache actually works.Finally, a new CI step adds code coverage measurements using
cargo-llvmand uploads the results to Coveralls.