-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decl_hdf5 MPI-I/O Collective or Independent, fix #419 #502
Conversation
Previous review are in #494 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
Three minor comments to change.
plugins/decl_hdf5/tests/compatibility_tests/PDI_C/mpi_independent_read_test.c
Outdated
Show resolved
Hide resolved
plugins/decl_hdf5/tests/compatibility_tests/PDI_C/mpi_independent_write_test.c
Outdated
Show resolved
Hide resolved
Co-authored-by: Benoit Martin <[email protected]>
be90055
Co-authored-by: Benoit Martin <[email protected]>
Co-authored-by: Benoit Martin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* decl_hdf5 MPIO Collective or Independent, fix #419 * fix compilation error + add compatibilty test with independent I/O * fix419:resolve Datatype_template_sptr error + Add change in local CHANGELOG.md * fix419: add mpio in full configuration example of the doc * fix419: fix name of parameter * fixing review * replace MPIIO by MPI-I/O + add argument to main + fix some typo * fix review * Update plugins/decl_hdf5/dataset_op.cxx Co-authored-by: Benoit Martin <[email protected]> * Update plugins/decl_hdf5/dataset_op.cxx Co-authored-by: Benoit Martin <[email protected]> * Update plugins/decl_hdf5/dataset_op.cxx Co-authored-by: Benoit Martin <[email protected]> * fix bug --------- Co-authored-by: Karol Sierocinski <[email protected]> Co-authored-by: yushan wang <[email protected]> Co-authored-by: Benoit Martin <[email protected]> Co-authored-by: Yacine Ould Rouis - CNRS <[email protected]> Co-authored-by: Julien Bigot <[email protected]>
* decl_hdf5 MPIO Collective or Independent, fix #419 * fix compilation error + add compatibilty test with independent I/O * fix419:resolve Datatype_template_sptr error + Add change in local CHANGELOG.md * fix419: add mpio in full configuration example of the doc * fix419: fix name of parameter * fixing review * replace MPIIO by MPI-I/O + add argument to main + fix some typo * fix review * Update plugins/decl_hdf5/dataset_op.cxx Co-authored-by: Benoit Martin <[email protected]> * Update plugins/decl_hdf5/dataset_op.cxx Co-authored-by: Benoit Martin <[email protected]> * Update plugins/decl_hdf5/dataset_op.cxx Co-authored-by: Benoit Martin <[email protected]> * fix bug --------- Co-authored-by: Karol Sierocinski <[email protected]> Co-authored-by: yushan wang <[email protected]> Co-authored-by: Benoit Martin <[email protected]> Co-authored-by: Yacine Ould Rouis - CNRS <[email protected]> Co-authored-by: Julien Bigot <[email protected]>
Possibility to choose parallel MPIIO pointer (COLLECTIVE/INDEPENDENT) for hdf5 in parallel.
List of things to check before making a PR
Before merging your code, please check the following:
.clang-format
;Fix #issue
keyword to autoclose the issue when merged.