Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aug #194

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Aug #194

wants to merge 4 commits into from

Conversation

yuntongf
Copy link

No description provided.

@@ -0,0 +1 @@
nodeLinker: node-modules
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HmMmmMMmM

"alumnus": false,
"graduation_year": 2025,
"job": null
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: new line

"hometown": "Tianjin China",
"team": "Penn Courses",
"roles": ["Frontend Engineer"],
"photo": "https://media.licdn.com/dms/image/D4E03AQHKm_uMFR55Zw/profile-displayphoto-shrink_800_800/0/1686604042664?e=1701302400&v=beta&t=0S1WNZkHfjgYDwf2ky2BBLLgFI0tqx0ww1Jkptk0h2Y",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's easy for this type of photo to no longer have a valid URL after a certain period of time. Rather than right clicking on LinkedIn profile to copy image URL, I would recommend using a hosting site like Imgur.

"major": "Computer Science",
"school": "Engineering",
"bio": "Salt air, and the rust on your door\n I never needed anything more\n Whispers of \"Are you sure?\" \nNever have I ever before\"",
"hometown": "Tianjin China",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nit, maybe add a ,.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants