Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aug #194

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Aug #194

Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .yarnrc.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
nodeLinker: node-modules
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HmMmmMMmM

18 changes: 18 additions & 0 deletions src/json/members/august.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"name": "August Fu",
"pennkey": "yuntongf",
"major": "Computer Science",
"school": "Engineering",
"bio": "Salt air, and the rust on your door\n I never needed anything more\n Whispers of \"Are you sure?\" \nNever have I ever before\"",
"hometown": "Tianjin China",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nit, maybe add a ,.

"team": "Penn Courses",
"roles": ["Frontend Engineer"],
"photo": "https://media.licdn.com/dms/image/D4E03AQHKm_uMFR55Zw/profile-displayphoto-shrink_800_800/0/1686604042664?e=1701302400&v=beta&t=0S1WNZkHfjgYDwf2ky2BBLLgFI0tqx0ww1Jkptk0h2Y",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's easy for this type of photo to no longer have a valid URL after a certain period of time. Rather than right clicking on LinkedIn profile to copy image URL, I would recommend using a hosting site like Imgur.

"linkedin": "https://www.linkedin.com/in/august-fu/",
"website": "",
"github": "https://github.com/yuntongf",
"semester_joined": "2022C",
"alumnus": false,
"graduation_year": 2025,
"job": null
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: new line

Loading