Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need an "Upload All Dependencies" button #600 #616

Merged
merged 8 commits into from
Aug 15, 2023
Merged

Need an "Upload All Dependencies" button #600 #616

merged 8 commits into from
Aug 15, 2023

Conversation

Eduardodudu
Copy link
Collaborator

Task

Feature task on the option to upload all packages #600

This PR adds:

  1. A structure for uploading all packages under package dependencies
  2. It only updates packages that are not already uploaded
  3. Reuses the component of uploading single packages
  4. Added some lint for the code

image
image
image
image

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #616 (ef905bc) into dev (fa41c3a) will decrease coverage by 0.66%.
The diff coverage is 8.75%.

❗ Current head ef905bc differs from pull request most recent head 419e57c. Consider uploading reports for the commit 419e57c to get more accurate results

@@            Coverage Diff             @@
##              dev     #616      +/-   ##
==========================================
- Coverage   77.32%   76.66%   -0.66%     
==========================================
  Files          29       29              
  Lines        3863     3904      +41     
==========================================
+ Hits         2987     2993       +6     
- Misses        876      911      +35     
Files Changed Coverage Δ
R/mod_packageDependencies.R 15.85% <8.75%> (-2.43%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Eduardodudu Eduardodudu marked this pull request as ready for review August 14, 2023 19:36
@Robert-Krajcik
Copy link
Contributor

Robert-Krajcik commented Aug 15, 2023

Hi @Eduardodudu

Thanks for working on this.
Since I wrote the mod-packageDepencencies code, I wanted to take a look at your PR.
I just have one comment:
Base R packages should not be included in the count of packages to be loaded, nor should they be loaded.
The message here should be
"There are no new packages to upload."

Thanks!

image

Suggested change at about line 336:
pkgs_update <- pkg_df() %>%
dplyr::filter(is.na(score) | score == "") %>%
dplyr::filter(!name %in% c(rownames(installed.packages(priority = "base"))))

@Eduardodudu Eduardodudu requested review from Jeff-Thompson12 and Robert-Krajcik and removed request for Jeff-Thompson12 August 15, 2023 14:37
@Eduardodudu
Copy link
Collaborator Author

Eduardodudu commented Aug 15, 2023

Hi @Eduardodudu

Thanks for working on this. Since I wrote the mod-packageDepencencies code, I wanted to take a look at your PR. I just have one comment: Base R packages should not be included in the count of packages to be loaded, nor should they be loaded. The message here should be "There are no new packages to upload."

Thanks!

image

Suggested change at about line 336: pkgs_update <- pkg_df() %>% dplyr::filter(is.na(score) | score == "") %>% dplyr::filter(!name %in% c(rownames(installed.packages(priority = "base"))))

Thank you @Robert-Krajcik !! Updated!!

Merge branch 'dev' into ea-600

# Conflicts:
#	DESCRIPTION
#	R/mod_packageDependencies.R
Copy link
Contributor

@Robert-Krajcik Robert-Krajcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, Eduardo.
Just one more issue.
Can you get rid of this message?}
The name provided ('fas fa-upload fa-solid') does not correspond to a known icon

Copy link
Contributor

@Robert-Krajcik Robert-Krajcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Eduardodudu Eduardodudu merged commit b4e57a0 into dev Aug 15, 2023
3 checks passed
@AARON-CLARK AARON-CLARK deleted the ea-600 branch August 29, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants