Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Python 3.12 support #888

Merged
merged 7 commits into from
Nov 3, 2023
Merged

add Python 3.12 support #888

merged 7 commits into from
Nov 3, 2023

Conversation

dantownsend
Copy link
Member

Making sure the tests run for Python 3.12, and it's shown in PyPI.

@dantownsend dantownsend added the enhancement New feature or request label Oct 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2023

Codecov Report

Merging #888 (b25c359) into master (febe5bb) will decrease coverage by 0.76%.
The diff coverage is 66.66%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #888      +/-   ##
==========================================
- Coverage   92.11%   91.36%   -0.76%     
==========================================
  Files         107      107              
  Lines        8115     8115              
==========================================
- Hits         7475     7414      -61     
- Misses        640      701      +61     
Files Coverage Δ
piccolo/apps/migrations/auto/schema_differ.py 97.72% <ø> (ø)
piccolo/querystring.py 92.40% <100.00%> (-1.27%) ⬇️
piccolo/table.py 96.87% <100.00%> (ø)
piccolo/query/mixins.py 92.72% <50.00%> (-0.81%) ⬇️

... and 17 files with indirect coverage changes

@dantownsend
Copy link
Member Author

The CI is failing because of slotscheck - Python 3.12 has changed generics.

@dantownsend
Copy link
Member Author

dantownsend commented Nov 3, 2023

Asked about slotscheck with Python 3.12 generics here: ariebovenberg/slotscheck#201

For now, will skip it for Python 3.12 until I can figure out what to do properly.

@dantownsend dantownsend merged commit 6cb005b into master Nov 3, 2023
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants