This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
Ci system tests #39
Merged
Ci system tests #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we can run tests in parallel == faster
I set all the KB tests to run in one pytest-xdist process, so they will run one after the other - since they are all using the same index
Otherwise we get very ugly reports
I accidentally distributed the unit tests with python-xdist, instead of the slow system tests
igiloh-pinecone
force-pushed
the
ci_system_tests
branch
from
5a278fb to
f8854a3
Compare
acatav
reviewed
Sep 10, 2023
| @@ -18,6 +18,7 @@ pinecone-text = "^0.5.3" | |||
| flake8-pyproject = "^1.2.3" | |||
| pandas-stubs = "^2.0.3.230814" | |||
| langchain = "^0.0.188" | |||
| pytest-xdist = "^3.3.1" | |||
There was a problem hiding this comment.
shouldn't this one be under the dev dependencies?
acatav
approved these changes
Sep 10, 2023
| @@ -46,11 +46,17 @@ jobs: | |||
| version: 1.3.2 | |||
| - name: install dependencies | |||
| run: poetry install --with dev --all-extras | |||
| - name: Run pytest | |||
| run: poetry run pytest -v --html=report.html tests/unit | |||
| - name: Run unit tests | |||
There was a problem hiding this comment.
Note that we restrict in the toml the python to be ^3.9 and the matrix starts from 3.8 so:
- we should remove 3.8 from the matrix
- the CI automatically finds an env that compatible so for 3.8 it actually use 3.10. We should restrict that since we want to make sure we actually test on the env we think we are testing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
System tests not running in CI
Solution
pytest-xdistto run tests in parallelType of Change
Test Plan
That's the whole point...