Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Spruce workflows #217

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Fix Spruce workflows #217

merged 1 commit into from
Oct 13, 2023

Conversation

austin-denoble
Copy link
Contributor

Problem

For managing Spruce artifacts I added a new command in the makefile, but I didn't update .PHONY: at the top of the file to include the new command.

Solution

  • Add upload-spruce to .PHONY: in the Makefile.
  • Remove some unneeded ids from release-spruce and nightly-spruce-dev-release.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Infrastructure change (CI configs, etc)

Test Plan

Re-run workflows with corrected make.

@austin-denoble austin-denoble requested a review from jhamon October 12, 2023 14:42
@austin-denoble austin-denoble merged commit 3fccb12 into main Oct 13, 2023
@austin-denoble austin-denoble deleted the adenoble/fix-spruce-workflows branch October 13, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants