Support passing custom host for Index operations #218
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We need support for supplying a custom
host
value for index operations.Solution
pinecone.init()
andConfig
already support the ability to supply a customhost
. It didn't seem like it was being passed through to theApiClient
:_get_api_instance()
inmanage.py
to check for aConfig.CONTROLLER_HOST
value, and apply it to theclient_config
if so. This will then be used throughout the index operations.manage.py
, test settingcontroller_host
and timeout functionality increate_index
/delete_index
.Type of Change
Test Plan
Pull this branch down and test locally. I validated myself by passing a bogus
host
in and looking over the errors, then passing the properhost
viainit
to validate it works properly.