Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Incorporate poetry changes into nightly build workflows #225

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

jhamon
Copy link
Collaborator

@jhamon jhamon commented Oct 19, 2023

Problem

Nightly builds have not succeeded since poetry stuff got merged a couple of weeks ago. This is because the version update step was not updated to change the version number in pyproject.toml and pypi complained of version conflicts.

Solution

Use poetry to set version in pyproject.toml before uploading to pypi.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Infrastructure change (CI configs, etc)

Copy link
Contributor

@austin-denoble austin-denoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for getting this cleaned up.

@jhamon jhamon merged commit 591b8fb into main Oct 20, 2023
@jhamon jhamon deleted the jhamon/fix-nightly-build branch October 20, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants