forked from activemerchant/active_merchant
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2024 06 sync upstream #15
Open
justingrobles
wants to merge
390
commits into
master
Choose a base branch
from
feature/2024-06-sync-upstream
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor IPG credentials to accept a combined user ID/store ID string since this is what is provided to IPG merchants as their user ID. ECS-2839 Unit: 31 tests, 135 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications, 100% passed Remote: 18 tests, 42 assertions, 6 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications, 66.6667% passed Closes activemerchant#4854
Update generate_purchase_number_stamp to always produce unique 12-digit alphanumberic value even if multiple transactions occur at the same time. Unit: 16 tests, 100 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Add new OAuth Response error handling to PayTrace, Quickbooks, Simetrik, Alelo, CheckoutV2 and Airwallex.
This reverts commit 00fd53f.
Cybersource's legacy gateway supports recurring transactions for Network Tokens. The way to accomplish this is to not send the `cryptogram` since that is one time use and mark the `commerce_indicator` as `internet`. Remote: 123 tests, 619 assertions, 5 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 95.935% passed 5 tests failing on master
This reverts commit ee2ac1a.
To specifiy the SCA exemption that a trasaction will be claming. Remote: 105 tests, 559 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 94 tests, 207 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Update Verify to use verifycard endpoint. Unit: 19 tests, 85 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 32 tests, 88 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 96.875% passed
…#4860) Description ------------------------- [SER-653](https://spreedly.atlassian.net/browse/SER-653) [SER-654](https://spreedly.atlassian.net/browse/SER-654) [SER-655](https://spreedly.atlassian.net/browse/SER-655) [SER-662](https://spreedly.atlassian.net/browse/SER-662) Shift4 purchased Securion Pay and is now using their API, that's why this commit enable a new shift4_v2 gateway Unit test ------------------------- Finished in 0.150258 seconds. 34 tests, 191 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote test ------------------------- Finished in 28.137188 seconds. 30 tests, 103 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop ------------------------- 760 files inspected, no offenses detected Co-authored-by: cristian <[email protected]>
Description ------------------------- This commit add a couple of test to be sure that we are sending the three_d_required field as a GSF in order to perform a 3DS gateway specific in Rapyd. Additional enable execute 3ds gateway specific when the execute_threed option is true. Unit test ------------------------- Finished in 0.076246 seconds. 27 tests, 140 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 354.12 tests/s, 1823.05 assertions/s Remote test ------------------------- Finished in 113.329864 seconds. 34 tests, 99 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.0588% passed 0.30 tests/s, 0.86 assertions/s Rubocop ------------------------- 763 files inspected, no offenses detected Co-authored-by: Javier Pedroza <[email protected]>
Local: 5588 tests, 77757 assertions, 0 failures, 19 errors, 0 pendings, 0 omissions, 0 notifications 99.66% passed Unit: 15 tests, 68 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 13 tests, 42 assertions, 2 failures, 1 errors, 0 pendings, 0 omissions, 0 notifications 76.9231% passed Note: I removed the test_verify_credentials because even the 'unknown' fixture creds were returning 400 response codes which is the same as the actual fixures
Cybersource's legacy gateway supports recurring transactions for Network Tokens. The way to accomplish this is to not send the `cryptogram` since that is one time use and mark the `commerce_indicator` as `internet`. Remote: 123 tests, 619 assertions, 5 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 95.935% passed 5 tests failing on master
…rve and tests related to it. (activemerchant#4875) Co-authored-by: Nick Ashton <[email protected]>
Local: 5588 tests, 77761 assertions, 0 failures, 19 errors, 0 pendings, 0 omissions, 0 notifications 99.66% passed Unit: 27 tests, 137 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 34 tests, 95 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Description ------------------------- This commit add new headers identifiers: 'x-originator', 'user-agent'. Additionally include a small test to verify the headers presence. [SER-621](https://spreedly.atlassian.net/browse/SER-621) Unit test ------------------------- Finished in 0.033772 seconds. 25 tests, 175 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 740.26 tests/s, 5181.81 assertions/s Remote test ------------------------- Finished in 57.0542 seconds. 26 tests, 62 assertions, 5 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 80.7692% passed 0.46 tests/s, 1.09 assertions/s Rubocop ------------------------- 763 files inspected, no offenses detected Co-authored-by: Javier Pedroza <[email protected]>
Local: 5589 tests, 77761 assertions, 0 failures, 19 errors, 0 pendings, 0 omissions, 0 notifications 99.66% passed Unit: 111 tests, 583 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 134 tests, 447 assertions, 11 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 91.791% passed
Description ------------------------- [SER-808](https://spreedly.atlassian.net/browse/SER-808) This commit validate if the cvv in order to don't allow send empty values to Rapyd This commit also include a small update for the previos work made for [3ds Gateway Specific](activemerchant#4876) Unit test ------------------------- Finished in 0.183111 seconds. 29 tests, 148 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notificationsomissions, 0 notifications 100% passed 158.37 tests/s, 808.25 assertions/s Remote test ------------------------- Finished in 113.329864 seconds. 34 tests, 111 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.0588% passed 0.30 tests/s, 0.86 assertions/s Rubocop ------------------------- 763 files inspected, no offenses detected Co-authored-by: Javier Pedroza <[email protected]>
Test Summary Local: 5591 tests, 77934 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit at test/unit/gateways/cyber_source_test.rb: 138 tests, 762 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote at test/remote/gateways/remote_cyber_source_test.rb: 125 tests, 627 assertions, 5 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 96% passed (same as `master`)
The `last4` field is the only new `option`, and is added upstream. This work includes fields for one-time use PaymentIntents only. Test Summary Local: 5582 tests, 77796 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit at test/unit/gateways/stripe_payment_intents_test.rb: 55 tests, 289 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote at test/remote/gateways/remote_stripe_payment_intents_test.rb: 90 tests, 424 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Summary: ------------------------------ Fixes a bug for Shift4 gateway to ensure that currency code is downcased. SER-811 Remote Test: ------------------------------ Finished in 34.37861 seconds. 34 tests, 121 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit Tests: ------------------------------ Finished in 47.584817 seconds. 5604 tests, 78022 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed RuboCop: ------------------------------ 766 files inspected, no offenses detected
Description ------------------------- Setup, scrub and purchase method to SumUp Gateway adapter with the basic information needed. This are the relevant links to review the initial implementation: [SumUp REST API](https://developer.sumup.com/docs/api/sum-up-rest-api/) [Make a payment with a card entered by a customer](https://developer.sumup.com/docs/online-payments/guides/single-payment/) [Checkouts](https://developer.sumup.com/docs/api/checkouts/) Tickets for Spreedly reference SER-764 SER-712 SER-711 Unit test ------------------------- Finished in 31.732818 seconds. 5611 tests, 78033 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications Remote test ------------------------- 100% passed 176.82 tests/s, 2459.06 assertions/s Rubocop ------------------------- Inspecting 769 files 769 files inspected, no offenses detected Co-authored-by: Luis <[email protected]> Co-authored-by: Nick Ashton <[email protected]>
Description ------------------------- [SER-763](https://spreedly.atlassian.net/browse/SER-763) This commit add the initial setup for the new Xpay gateway Unit test ------------------------- Finished in 0.557754 seconds. 2 tests, 4 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 3.59 tests/s, 7.17 assertions/s Remote test ------------------------- Finished in 0.557754 seconds. 2 tests, 4 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 3.59 tests/s, 7.17 assertions/s Rubocop ------------------------- 769 files inspected, no offenses detected Co-authored-by: Javier Pedroza <[email protected]>
…emerchant#4895) Description ------------------------- [SER-826](https://spreedly.atlassian.net/browse/SER-826) This commit add some validations to not send the cvv and network_reference_id on recurring transactions if it does not exist Unit test ------------------------- Finished in 0.132965 seconds. 34 tests, 163 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote test ------------------------- Finished in 79.856446 seconds. 40 tests, 115 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.5% passed Rubocop ------------------------- 766 files inspected, no offenses detected Co-authored-by: Javier Pedroza <[email protected]>
* Rapyd: Fix cvv validation Description ------------------------- This is a super small commit to update the validations to not send cvv value Unit test ------------------------- Finished in 0.132965 seconds. 34 tests, 163 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote test ------------------------- Finished in 79.856446 seconds. 40 tests, 115 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.5% passed Rubocop ------------------------- 766 files inspected, no offenses detected * Improve logic to check for valid ntid when deciding if we should send the * Use .blank? to check for cvv and validate presence of ntid before cvv check --------- Co-authored-by: Javier Pedroza <[email protected]> Co-authored-by: naashton <[email protected]>
Summary: ------------------------------ This PR adds support for FlexCharge gateway adding the evaluate and refund operations [SER-1130](https://spreedly.atlassian.net/browse/SER-1130) Remote Test: ------------------------------ Finished in 39.651458 seconds. 12 tests, 40 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 91.6667% passed *Note:* Failing test happens because of account limit on refunds Unit Tests: ------------------------------ Finished in 33.453236 seconds. 5855 tests, 79334 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed RuboCop: ------------------------------ 795 files inspected, no offenses detected
Summary: ------------------------------ This PR enables Shift4v2 to implement TPV on Bank accounts and adds support to store CreditCards directly on the 'cards' end-point [SER-1219](https://spreedly.atlassian.net/browse/SER-1219) Remote Test: ------------------------------ Finished in 52.459288 seconds. 47 tests, 166 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit Tests: ------------------------------ Finished in 40.844376 seconds. 5848 tests, 79304 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed RuboCop: ------------------------------ 792 files inspected, no offenses detected
* Worldpay: Update stored creds COMP-42 Adds tests to ensure stored credentials are passed for network tokens and adds the ability to override the NTID from the standard framework Test Summary Local: 5867 tests, 79281 assertions, 0 failures, 23 errors, 0 pendings, 0 omissions, 0 notifications 99.608% passed Unit: 117 tests, 662 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 104 tests, 447 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 98.0769% passed * remove ntid override * add test * changelog * rubocop
Summary: ----- This PR includes for Datatrans the NetworkToken, ApplePay, and GooglePay code to perform transactions with that PM [SER-1195](https://spreedly.atlassian.net/browse/SER-1195) Tests ----- Remote Test: Finished in 23.393965 seconds. 19 tests, 51 assertions, 0 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications 100% passed Unit Tests: 23 tests, 111 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed RuboCop: 795 files inspected, no offenses detected Co-authored-by: Gustavo Sanmartin <[email protected]> Co-authored-by: Edgar Villamarin <[email protected]>
Add support for encrypted ApplePay and GooglePay.
This reverts commit 0c95361.
Update success_from method to take current_status for the first message to evaluate. If the transaction type is refund the successful current_status base on CANCELLED if status is also success Remote 34 tests, 85 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit 33 tests, 137 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Summary: ----- This includes to Datatrans gateway, the params to required to support 3DS global. [SER-1197](https://spreedly.atlassian.net/browse/SER-1197) Tests ----- Remote Test: Finished in 24.693965 seconds. 21 tests, 55 assertions, 0 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications 100% passed Unit Tests: 24 tests, 129 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed RuboCop: 798 files inspected, no offenses detected
Description ------------------------- This commit adds 3ds options for FlexCharge, adding suppport for 3ds Global Unit test ------------------------- 13 tests, 70 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 480.43 tests/s, 2586.94 assertions/s Remote test ------------------------- Finished in 32.878446 seconds. 13 tests, 39 assertions, 0 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications 100% passed 0.40 tests/s, 1.19 assertions/s Rubocop ------------------------- 798 files inspected, no offenses detected
* Flex Charge: Add support for TPV store Test summary: Local: 5898 tests, 79569 assertions, 0 failures, 17 errors, 0 pendings, 0 omissions, 0 notifications 99.7118% passed Unit: 12 tests, 58 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 13 tests, 34 assertions, 1 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications 91.6667% passed
Description ------------------------- This commit fixes the parse authorization string when the first value is nil also fixes a issue trying to get the payment_method.brand when the payment method is not a credit card Unit test ------------------------- Finished in 0.800901 seconds. 23 tests, 59 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 28.72 tests/s, 73.67 assertions/s Remote test ------------------------- Finished in 9.141401 seconds. 1 tests, 6 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 0.11 tests/s, 0.66 assertions/s Rubocop ------------------------- 795 files inspected, no offenses detected Co-authored-by: Javier Pedroza <[email protected]>
A previous commit removed the default ECI value for NT type payment methods (apple pay, google pay, and network tokens) from the Worldpay integration. This value was previously '07' and added if an ECI was not present. This commit removed the default behavior as this was not compliant with GooglePay standards and Worldpay's documentation indicated it was an option field. Upon implementing, some merchants have found issues with Mastercard Google Pay transactions lacking an ECI. This is an attempt at an opt-in revert where if a merchant needs to go back to the original commit they can do so by passing in use_default_eci. Test Summary Local: 5906 tests, 79606 assertions, 0 failures, 23 errors, 0 pendings, 0 omissions, 0 notifications 99.6106% passed Unit: 120 tests, 675 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 106 tests, 455 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.1698% passed
A bit of refactoring was needed in the gateway file to support these fields and get things in better shape with adhering to the XSD. Unit tests are now more comprehensive to check schema. I added a remote test and left comments to indicate which fields are restricted to Canadian merchants. Unit Tests: 148 tests, 850 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote Tests: 134 tests, 504 assertions, 8 failures, 11 errors, 0 pendings, 0 omissions, 0 notifications 85.8209% passed *Same number of failures and errors on master. Local Tests: 5899 tests, 79647 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Spreedly reference: [ECS-3492](https://spreedly.atlassian.net/browse/ECS-3492) Unit tests Finished in 27.620662 seconds. 5849 tests, 79313 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed RuboCop 792 files inspected, no offenses detected
Description ------------------------- This commit fix a issue for set the payment method brand for payment_product when is mastercard Unit test ------------------------- Finished in 1.799922 seconds. 24 tests, 64 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 13.33 tests/s, 35.56 assertions/s Remote test ------------------------- Finished in 132.781957 seconds. 18 tests, 76 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications Rubocop ------------------------- 798 files inspected, no offenses detected Co-authored-by: Javier Pedroza <[email protected]>
Summary: ------------------------------ This PR adds the Inquire call to FlexCharge adapter [SER-1153](https://spreedly.atlassian.net/browse/SER-1153) Remote Test: ------------------------------ Finished in 38.700031 seconds. 16 tests, 43 assertions, 0 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications 100% passed Unit Tests: ------------------------------ Finished in 40.844376 seconds. 5848 tests, 79304 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed RuboCop: ------------------------------ 798 files inspected, no offenses detected
Add support of encrypted ApplePay and GooglePay payload. Unit: 49 tests, 249 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 39 tests, 174 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 94.8718% passed
* Cybersource Rest: Support L2/L3 data COMP-134 Adds support for L2 and L3 data to the Cybersource Rest gateway Test Summary Local: 5882 tests, 79430 assertions, 0 failures, 23 errors, 0 pendings, 0 omissions, 0 notifications 99.609% passed Unit: 36 tests, 189 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: * Worldpay: Refactor L2/L3 data COMP-134 Refactor L2/L3 data for Worldpay to be more in line with how active merchant gateways expect this data. It also lowers the burden for what merchants must provide to use L2/L3 data Test Summary Local: 5883 tests, 79441 assertions, 0 failures, 23 errors, 0 pendings, 0 omissions, 0 notifications 99.609% passed Unit: 117 tests, 668 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 103 tests, 444 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 98.0583% passed * change total amount to not be summed * remove commented out code * rename to line_items * changelog
Description ------------------------- This commit enable AUTP card type to be used as a valid credit card Unit test ------------------------- Finished in 0.041087 seconds. 70 tests, 661 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 1703.70 tests/s, 16087.81 assertions/s Rubocop ------------------------- 798 files inspected, no offenses detected Co-authored-by: Javier Pedroza <[email protected]>
Updated ruby version and fixed a few remote test suites.
FlexCharge: Adding Inquire support Summary: ------------------------------ Changes FlexCharge inquire call to reflect deprecated end-point [SER-1153](https://spreedly.atlassian.net/browse/SER-1153) Remote Test: ------------------------------ Finished in 38.700031 seconds. 16 tests, 43 assertions, 0 failures, 3 errors, 0 pendings, 1 omissions, 0 notifications 100% passed Unit Tests: ------------------------------ Finished in 62.753266 seconds. 5923 tests, 79804 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed RuboCop: ------------------------------ 798 files inspected, no offenses detected
141 and 142 are successful responses for prepaid cards. Unit: 61 tests, 274 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 57 tests, 250 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 98.2456% passed
* Braintree and Worldpay: support overriding NTID COMP-160 Adds support for the Braintree Blue and Worldpay gateways for merchants to override and bring their own NTID instead of relying on the standardized NTID framework Test Summary Local: 5908 tests, 79610 assertions, 0 failures, 23 errors, 0 pendings, 0 omissions, 0 notifications 99.6107% passed Unit: Worldpay: 119 tests, 672 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Braintree: 104 tests, 219 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: Worldpay: 104 tests, 447 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.1154% passed Braintree: 120 tests, 646 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed * PR feedback * changelog
* Cybersource Rest: Stored Credential refactor COMP-78 Refactors the stored credential support for the Cybersource Rest gateway to be in-line with their documentation. Also repairs test suite for this gateway by eliminating certain tests and fixing others. Test summary: Local: 5838 tests, 79156 assertions, 2 failures, 23 errors, 0 pendings, 0 omissions, 0 notifications 99.5718% passed Unit: 30 tests, 144 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 43 tests, 143 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed * PR feedback * pending * wip * remove old code * changelog
SER-140 add support to make purchase, authorize transactions using network tokens in the plexo gateway Test summary: Local: 5910 tests, 79650 assertions, 0 failures, 17 errors, 0 pendings, 0 omissions, 0 notifications 99.7124% passed Unit: 25 tests, 134 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 32 tests, 36 assertions, 21 failures, 3 errors, 0 pendings, 3 omissions, 0 notifications 17.2414% passed
bwerdschinski
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
damienjbyrne
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
Description
This is just to sync up our current fork with latest Upstream changes.
Includes a few FDP Data (Phone Number and Customer Name) as well as security updates (like Ruby Version 3.1.4).
Reference