2024 06 sync upstream

.github/workflows/ruby-ci.yml

@@ -17,9 +17,7 @@ jobs:
     strategy:
       matrix:
         version:
-          - 2.5
-          - 2.6
-          - 2.7
+          - 3.1
         gemfile:
           - gemfiles/Gemfile.rails50
           - gemfiles/Gemfile.rails51

.github/workflows/stale.yml

@@ -0,0 +1,19 @@
+name: 'Close stale issues and PRs'
+on:
+  schedule:
+    - cron: '30 1 * * *'
+
+permissions:
+  issues: write
+  pull-requests: write
+
+jobs:
+  stale:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/stale@v8
+        with:
+          stale-issue-message: 'To provide a cleaner slate for the maintenance of the library, this PR/Issue is being labeled stale after 60 days without activity. It will be closed in 14 days unless you comment with an update regarding its applicability to the current build. Thank you!'
+          stale-pr-message: 'To provide a cleaner slate for the maintenance of the library, this PR/Issue is being labeled stale after 60 days without activity. It will be closed in 14 days unless you comment with an update regarding its applicability to the current build. Thank you!'
+          days-before-close: 14
+          exempt-draft-pr: true

.rubocop.yml

@@ -15,7 +15,7 @@ AllCops:
     - "lib/active_merchant/billing/gateways/paypal_express.rb"
     - "vendor/**/*"
   ExtraDetails: false
-  TargetRubyVersion: 2.5
+  TargetRubyVersion: 3.1
 
 # Active Merchant gateways are not amenable to length restrictions
 Metrics/ClassLength:
@@ -24,7 +24,7 @@ Metrics/ClassLength:
 Metrics/ModuleLength:
   Enabled: false
 
-Layout/AlignParameters:
+Layout/ParameterAlignment:
   EnforcedStyle: with_fixed_indentation
 
 Layout/DotPosition:
@@ -33,10 +33,96 @@ Layout/DotPosition:
 Layout/CaseIndentation:
   EnforcedStyle: end
 
-Layout/IndentHash:
+Layout/FirstHashElementIndentation:
   EnforcedStyle: consistent
 
 Naming/PredicateName:
   Exclude:
     - "lib/active_merchant/billing/gateways/payeezy.rb"
     - 'lib/active_merchant/billing/gateways/airwallex.rb'
+
+Gemspec/DateAssignment: # (new in 1.10)
+  Enabled: true
+Layout/SpaceBeforeBrackets: # (new in 1.7)
+  Enabled: true
+Lint/AmbiguousAssignment: # (new in 1.7)
+  Enabled: true
+Lint/DeprecatedConstants: # (new in 1.8)
+  Enabled: true # update later in next Update Rubocop PR
+Lint/DuplicateBranch: # (new in 1.3)
+  Enabled: false
+Lint/DuplicateRegexpCharacterClassElement: # (new in 1.1)
+  Enabled: true
+Lint/EmptyBlock: # (new in 1.1)
+  Enabled: false # update later in next Update Rubocop PR
+  Exclude:
+    - 'lib/active_merchant/billing/gateways/authorize_net.rb'
+    - 'lib/active_merchant/billing/gateways/secure_net.rb'
+Lint/EmptyClass: # (new in 1.3)
+  Enabled: true
+Lint/FloatComparison:
+  Exclude:
+    - 'lib/active_merchant/billing/gateways/payu_latam.rb'
+Lint/LambdaWithoutLiteralBlock: # (new in 1.8)
+  Enabled: true
+Lint/NonDeterministicRequireOrder:
+  Exclude:
+    - 'script/generate'
+Lint/NoReturnInBeginEndBlocks: # (new in 1.2)
+  Enabled: true
+  Exclude:
+    - 'lib/active_merchant/billing/gateways/fat_zebra.rb'
+    - 'lib/active_merchant/billing/gateways/netbanx.rb'
+    - 'lib/active_merchant/billing/gateways/payway_dot_com.rb'
+Lint/NumberedParameterAssignment: # (new in 1.9)
+  Enabled: true
+Lint/OrAssignmentToConstant: # (new in 1.9)
+  Enabled: true
+Lint/RedundantDirGlobSort: # (new in 1.8)
+  Enabled: true
+Lint/SymbolConversion: # (new in 1.9)
+  Enabled: true
+Lint/ToEnumArguments: # (new in 1.1)
+  Enabled: true
+Lint/TripleQuotes: # (new in 1.9)
+  Enabled: true
+Lint/UnexpectedBlockArity: # (new in 1.5)
+  Enabled: true
+Lint/UnmodifiedReduceAccumulator: # (new in 1.1)
+  Enabled: true
+Style/ArgumentsForwarding: # (new in 1.1)
+  Enabled: true
+Style/CollectionCompact: # (new in 1.2)
+  Enabled: false # update later in next Update Rubocop PR
+Style/DocumentDynamicEvalDefinition: # (new in 1.1)
+  Enabled: true
+  Exclude:
+    - 'lib/active_merchant/billing/credit_card.rb'
+    - 'lib/active_merchant/billing/response.rb'
+Style/EndlessMethod: # (new in 1.8)
+  Enabled: true
+Style/HashConversion: # (new in 1.10)
+  Enabled: true
+  Exclude:
+    - 'lib/active_merchant/billing/gateways/payscout.rb'
+    - 'lib/active_merchant/billing/gateways/pac_net_raven.rb'
+Style/HashExcept: # (new in 1.7)
+  Enabled: true
+Style/IfWithBooleanLiteralBranches: # (new in 1.9)
+  Enabled: false # update later in next Update Rubocop PR
+Style/NegatedIfElseCondition: # (new in 1.2)
+  Enabled: true
+Style/NilLambda: # (new in 1.3)
+  Enabled: true
+Style/RedundantArgument: # (new in 1.4)
+  Enabled: false # update later in next Update Rubocop PR
+Style/StringChars: # (new in 1.12)
+  Enabled: false # update later in next Update Rubocop PR
+Style/SwapValues: # (new in 1.1)
+  Enabled: true
+Naming/VariableNumber:
+  Enabled: false
+Style/OptionalBooleanParameter:
+  Enabled: false
+Style/RedundantRegexpEscape:
+  Enabled: false

.rubocop_todo.yml

@@ -12,7 +12,7 @@
 # SupportedHashRocketStyles: key, separator, table
 # SupportedColonStyles: key, separator, table
 # SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
-Layout/AlignHash:
+Layout/HashAlignment:
   Enabled: false
 
 # Offense count: 150
@@ -26,7 +26,7 @@ Lint/FormatParameterMismatch:
     - 'test/unit/credit_card_formatting_test.rb'
 
 # Offense count: 2
-Lint/HandleExceptions:
+Lint/SuppressedException:
   Exclude:
     - 'lib/active_merchant/billing/gateways/mastercard.rb'
     - 'lib/active_merchant/billing/gateways/trust_commerce.rb'
@@ -65,6 +65,8 @@ Metrics/CyclomaticComplexity:
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
   Max: 163
+  IgnoredMethods: 
+    - 'setup'
 
 # Offense count: 2
 # Configuration parameters: CountKeywordArgs.
@@ -99,7 +101,7 @@ Naming/MethodName:
 # Offense count: 14
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
 # AllowedNames: io, id, to, by, on, in, at, ip, db
-Naming/UncommunicativeMethodParamName:
+Naming/MethodParameterName:
   Exclude:
     - 'lib/active_merchant/billing/gateways/blue_snap.rb'
     - 'lib/active_merchant/billing/gateways/cyber_source.rb'
@@ -173,13 +175,6 @@ Style/BarePercentLiterals:
 Style/BlockDelimiters:
   Enabled: false
 
-# Offense count: 440
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: braces, no_braces, context_dependent
-Style/BracesAroundHashParameters:
-  Enabled: false
-
 # Offense count: 2
 Style/CaseEquality:
   Exclude:
@@ -231,10 +226,34 @@ Style/ColonMethodCall:
 # Configuration parameters: Keywords.
 # Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW
 Style/CommentAnnotation:
-  Exclude:
-    - 'test/remote/gateways/remote_usa_epay_advanced_test.rb'
-    - 'test/unit/gateways/authorize_net_cim_test.rb'
-    - 'test/unit/gateways/usa_epay_advanced_test.rb'
+  Enabled: false # update later in next Update Rubocop PR
+
+Style/StringConcatenation:
+  Enabled: false # update later in next Update Rubocop PR
+Style/SingleArgumentDig:
+  Enabled: false # update later in next Update Rubocop PR
+Style/SlicingWithRange:
+  Enabled: false # update later in next Update Rubocop PR
+Style/HashEachMethods:
+  Enabled: false # update later in next Update Rubocop PR
+Style/CaseLikeIf:
+  Enabled: false # update later in next Update Rubocop PR
+Style/HashLikeCase:
+  Enabled: false # update later in next Update Rubocop PR
+Style/GlobalStdStream:
+  Enabled: false # update later in next Update Rubocop PR
+Style/HashTransformKeys:
+  Enabled: false # update later in next Update Rubocop PR
+Style/HashTransformValues:
+  Enabled: false # update later in next Update Rubocop PR
+Lint/RedundantSafeNavigation:
+  Enabled: false # update later in next Update Rubocop PR
+Lint/EmptyConditionalBody:
+  Enabled: false # update later in next Update Rubocop PR
+Style/SoleNestedConditional:
+  Exclude: # update later in next Update Rubocop PR
+    - 'lib/active_merchant/billing/gateways/card_connect.rb'
+    - 'lib/active_merchant/billing/gateways/blue_snap.rb'
 
 # Offense count: 8
 Style/CommentedKeyword:
@@ -381,17 +400,7 @@ Style/FormatString:
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: annotated, template, unannotated
 Style/FormatStringToken:
-  Exclude:
-    - 'lib/active_merchant/billing/gateways/redsys.rb'
-    - 'lib/active_merchant/connection.rb'
-    - 'lib/active_merchant/network_connection_retries.rb'
-    - 'test/remote/gateways/remote_balanced_test.rb'
-    - 'test/remote/gateways/remote_openpay_test.rb'
-    - 'test/unit/gateways/balanced_test.rb'
-    - 'test/unit/gateways/elavon_test.rb'
-    - 'test/unit/gateways/exact_test.rb'
-    - 'test/unit/gateways/firstdata_e4_test.rb'
-    - 'test/unit/gateways/safe_charge_test.rb'
+  Enabled: false
 
 # Offense count: 679
 # Cop supports --auto-correct.
@@ -410,6 +419,15 @@ Style/GlobalVars:
     - 'test/unit/gateways/finansbank_test.rb'
     - 'test/unit/gateways/garanti_test.rb'
 
+Lint/MissingSuper:
+ Exclude:
+  - 'lib/active_merchant/billing/gateways/payway.rb'
+  - 'lib/active_merchant/billing/response.rb'
+  - 'lib/active_merchant/billing/gateways/orbital/orbital_soft_descriptors.rb'
+  - 'lib/active_merchant/billing/gateways/orbital.rb'
+  - 'lib/active_merchant/billing/gateways/linkpoint.rb'
+  - 'lib/active_merchant/errors.rb'
+
 # Offense count: 196
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
@@ -448,6 +466,7 @@ Style/InverseMethods:
   Exclude:
     - 'lib/active_merchant/billing/gateways/ogone.rb'
     - 'lib/active_merchant/billing/gateways/worldpay.rb'
+  Enabled: false # update later in next Update Rubocop PR
 
 # Offense count: 32
 # Cop supports --auto-correct.
@@ -733,6 +752,6 @@ Style/ZeroLengthPredicate:
 # Offense count: 9321
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
-Metrics/LineLength:
+Layout/LineLength:
   Max: 2602